Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-27 Thread Kalle Valo
Brian Norris writes: > Hi, > > On Tue, Aug 25, 2020 at 8:38 AM Maximilian Luz > wrote: >> >> Following commit e18696786548 ("mwifiex: Prevent memory corruption >> handling keys") the mwifiex driver fails to authenticate with certain >> networks, specifically networks with 256 bit keys, and repe

Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-25 Thread Maximilian Luz
On 8/25/20 9:30 PM, Brian Norris wrote: Also, while technically the regressing commit (e18696786548 ("mwifiex: Prevent memory corruption handling keys")) was fixing a potential overflow, the encasing command structure (struct host_cmd_ds_command) is a union of a ton of other command layouts, and

Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-25 Thread Maximilian Luz
On 8/25/20 8:51 PM, Dan Carpenter wrote: I sort of feel like the code was broken before I added the bounds checking but it's also okay if the Fixes tag points to my change as well just to make backporting easier. I'd argue the same. Any critical out-of-bounds access was just never discovered (a

Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-25 Thread Brian Norris
Hi, On Tue, Aug 25, 2020 at 8:38 AM Maximilian Luz wrote: > > Following commit e18696786548 ("mwifiex: Prevent memory corruption > handling keys") the mwifiex driver fails to authenticate with certain > networks, specifically networks with 256 bit keys, and repeatedly asks > for the password. The

Re: [PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-25 Thread Dan Carpenter
On Tue, Aug 25, 2020 at 05:38:29PM +0200, Maximilian Luz wrote: > Following commit e18696786548 ("mwifiex: Prevent memory corruption > handling keys") the mwifiex driver fails to authenticate with certain > networks, specifically networks with 256 bit keys, and repeatedly asks > for the password. T

[PATCH net] mwifiex: Increase AES key storage size to 256 bits

2020-08-25 Thread Maximilian Luz
Following commit e18696786548 ("mwifiex: Prevent memory corruption handling keys") the mwifiex driver fails to authenticate with certain networks, specifically networks with 256 bit keys, and repeatedly asks for the password. The kernel log repeats the following lines (id and bssid redacted):