Re: [PATCH net] net: core: orphan frags before queuing to slow qdisc

2014-01-19 Thread Michael S. Tsirkin
On Fri, Jan 17, 2014 at 06:28:17AM -0800, Eric Dumazet wrote: > On Fri, 2014-01-17 at 17:42 +0800, Jason Wang wrote: > > Many qdiscs can queue a packet for a long time, this will lead an issue > > with zerocopy skb. It means the frags will not be orphaned in an expected > > short time, this breaks

Re: [PATCH net] net: core: orphan frags before queuing to slow qdisc

2014-01-19 Thread Michael S. Tsirkin
On Fri, Jan 17, 2014 at 05:42:14PM +0800, Jason Wang wrote: > Many qdiscs can queue a packet for a long time, this will lead an issue > with zerocopy skb. It means the frags will not be orphaned in an expected > short time, this breaks the assumption that virtio-net will transmit the > packet in ti

Re: [PATCH net] net: core: orphan frags before queuing to slow qdisc

2014-01-17 Thread Jason Wang
On 01/17/2014 10:28 PM, Eric Dumazet wrote: On Fri, 2014-01-17 at 17:42 +0800, Jason Wang wrote: Many qdiscs can queue a packet for a long time, this will lead an issue with zerocopy skb. It means the frags will not be orphaned in an expected short time, this breaks the assumption that virtio-ne

Re: [PATCH net] net: core: orphan frags before queuing to slow qdisc

2014-01-17 Thread Eric Dumazet
On Fri, 2014-01-17 at 17:42 +0800, Jason Wang wrote: > Many qdiscs can queue a packet for a long time, this will lead an issue > with zerocopy skb. It means the frags will not be orphaned in an expected > short time, this breaks the assumption that virtio-net will transmit the > packet in time. >

[PATCH net] net: core: orphan frags before queuing to slow qdisc

2014-01-17 Thread Jason Wang
Many qdiscs can queue a packet for a long time, this will lead an issue with zerocopy skb. It means the frags will not be orphaned in an expected short time, this breaks the assumption that virtio-net will transmit the packet in time. So if guest packets were queued through such kind of qdisc and