Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-18 Thread Xie He
On Sun, Oct 18, 2020 at 3:05 PM Jakub Kicinski wrote: > > Whenever you make a list like that it's a strong indication that > each of these should be a separate commit. That makes things easier > to review. > > > We have already sent a pull request for 5.10 and therefore net-next > is closed for

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-18 Thread Jakub Kicinski
On Fri, 16 Oct 2020 22:19:51 -0700 Xie He wrote: > 1. Change the fr_rx function to make this driver support any Ethertype > when receiving. (This driver is already able to handle any Ethertype > when sending.) > > Originally in the fr_rx function, the code that parses the long (10-byte) > header

[PATCH net-next] drivers/net/wan/hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-16 Thread Xie He
1. Change the fr_rx function to make this driver support any Ethertype when receiving. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recognizes a few Ethertype values and drops frames with