Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-04 Thread Andrew Lunn
On Thu, Sep 03, 2020 at 09:00:13PM -0700, Florian Fainelli wrote: > > > On 9/3/2020 3:03 PM, Andrew Lunn wrote: > > > The firmware provides the Device Tree but here is the relevant section for > > > you pasted below. The problematic device is a particular revision of the > > > silicon (D0) which

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-03 Thread Florian Fainelli
On 9/3/2020 3:03 PM, Andrew Lunn wrote: The firmware provides the Device Tree but here is the relevant section for you pasted below. The problematic device is a particular revision of the silicon (D0) which got later fixed (E0) however the Device Tree was created after the fixed platform, not

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-03 Thread Andrew Lunn
> The firmware provides the Device Tree but here is the relevant section for > you pasted below. The problematic device is a particular revision of the > silicon (D0) which got later fixed (E0) however the Device Tree was created > after the fixed platform, not the problematic one. Both revisions

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Florian Fainelli
On 9/2/2020 6:13 PM, Andrew Lunn wrote: On Wed, Sep 02, 2020 at 02:03:27PM -0700, Florian Fainelli wrote: Registering our slave MDIO bus outside of the OF infrastructure is necessary in order to avoid creating double references of the same Device Tree nodes, however it is not sufficient to

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Andrew Lunn
On Wed, Sep 02, 2020 at 02:03:27PM -0700, Florian Fainelli wrote: > Registering our slave MDIO bus outside of the OF infrastructure is > necessary in order to avoid creating double references of the same > Device Tree nodes, however it is not sufficient to guarantee that the > MDIO bus diversion

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread kernel test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-bcm_sf2-Ensure-that-MDIO-diversion-is-used/20200903-050536 base:

[PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Florian Fainelli
Registering our slave MDIO bus outside of the OF infrastructure is necessary in order to avoid creating double references of the same Device Tree nodes, however it is not sufficient to guarantee that the MDIO bus diversion is used because of_phy_connect() will still resolve to a valid PHY phandle