Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread David Miller
From: Vivien Didelot Date: Tue, 29 Sep 2015 12:38:36 -0400 > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened on a 6185 switch which does not

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Vivien Didelot
On Sep. Tuesday 29 (40) 06:42 PM, Andrew Lunn wrote: > On Tue, Sep 29, 2015 at 12:38:36PM -0400, Vivien Didelot wrote: > > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > > driver may return -EOPNOTSUPP from the commit phase of a STP state, > > which triggers a WARN() from

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Andrew Lunn
On Tue, Sep 29, 2015 at 12:38:36PM -0400, Vivien Didelot wrote: > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened on a 6185 switch which does not

[PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Vivien Didelot
Because of the default 0 value of ret in dsa_slave_port_attr_set, a driver may return -EOPNOTSUPP from the commit phase of a STP state, which triggers a WARN() from switchdev. This happened on a 6185 switch which does not support hardware bridging. Reported-by: Andrew Lunn Signed-off-by: Vivien

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Andrew Lunn
On Tue, Sep 29, 2015 at 12:38:36PM -0400, Vivien Didelot wrote: > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened on a 6185 switch which does not

[PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Vivien Didelot
Because of the default 0 value of ret in dsa_slave_port_attr_set, a driver may return -EOPNOTSUPP from the commit phase of a STP state, which triggers a WARN() from switchdev. This happened on a 6185 switch which does not support hardware bridging. Reported-by: Andrew Lunn

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread David Miller
From: Vivien Didelot Date: Tue, 29 Sep 2015 12:38:36 -0400 > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Vivien Didelot
On Sep. Tuesday 29 (40) 06:42 PM, Andrew Lunn wrote: > On Tue, Sep 29, 2015 at 12:38:36PM -0400, Vivien Didelot wrote: > > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > > driver may return -EOPNOTSUPP from the commit phase of a STP state, > > which triggers a WARN() from