Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-06-27 Thread David Miller
From: Yunsheng Lin Date: Tue, 25 Jun 2019 10:28:04 +0800 > So It is ok for me to fall back to reschedule the link watch wq > every 100 items, or is there a better way to fix it properly? Yes, that is fine for now.

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-06-24 Thread Yunsheng Lin
On 2019/5/29 16:59, Yunsheng Lin wrote: > On 2019/5/29 14:58, David Miller wrote: >> From: Yunsheng Lin >> Date: Mon, 27 May 2019 09:47:54 +0800 >> >>> When user has configured a large number of virtual netdev, such >>> as 4K vlans, the carrier on/off operation of the real netdev >>> will also

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-29 Thread Yunsheng Lin
On 2019/5/29 14:58, David Miller wrote: > From: Yunsheng Lin > Date: Mon, 27 May 2019 09:47:54 +0800 > >> When user has configured a large number of virtual netdev, such >> as 4K vlans, the carrier on/off operation of the real netdev >> will also cause it's virtual netdev's link state to be

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-29 Thread Yunsheng Lin
On 2019/5/29 16:12, Salil Mehta wrote: >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >> Behalf Of Yunsheng Lin >> Sent: Tuesday, May 28, 2019 2:04 AM >> >> On 2019/5/27 22:58, Stephen Hemminger wrote: >>> On Mon, 27 May 2019 09:47:54 +0800 >>> Yunsheng Lin wrote:

RE: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-29 Thread Salil Mehta
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Yunsheng Lin > Sent: Tuesday, May 28, 2019 2:04 AM > > On 2019/5/27 22:58, Stephen Hemminger wrote: > > On Mon, 27 May 2019 09:47:54 +0800 > > Yunsheng Lin wrote: > > > >> When user has configured a large

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-29 Thread David Miller
From: Yunsheng Lin Date: Mon, 27 May 2019 09:47:54 +0800 > When user has configured a large number of virtual netdev, such > as 4K vlans, the carrier on/off operation of the real netdev > will also cause it's virtual netdev's link state to be processed > in linkwatch. Currently, the processing

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-27 Thread Yunsheng Lin
On 2019/5/28 9:17, Stephen Hemminger wrote: > On Tue, 28 May 2019 09:04:18 +0800 > Yunsheng Lin wrote: > >> On 2019/5/27 22:58, Stephen Hemminger wrote: >>> On Mon, 27 May 2019 09:47:54 +0800 >>> Yunsheng Lin wrote: >>> When user has configured a large number of virtual netdev, such

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-27 Thread Stephen Hemminger
On Tue, 28 May 2019 09:04:18 +0800 Yunsheng Lin wrote: > On 2019/5/27 22:58, Stephen Hemminger wrote: > > On Mon, 27 May 2019 09:47:54 +0800 > > Yunsheng Lin wrote: > > > >> When user has configured a large number of virtual netdev, such > >> as 4K vlans, the carrier on/off operation of the

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-27 Thread Yunsheng Lin
On 2019/5/27 22:58, Stephen Hemminger wrote: > On Mon, 27 May 2019 09:47:54 +0800 > Yunsheng Lin wrote: > >> When user has configured a large number of virtual netdev, such >> as 4K vlans, the carrier on/off operation of the real netdev >> will also cause it's virtual netdev's link state to be

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-27 Thread Stephen Hemminger
On Mon, 27 May 2019 09:47:54 +0800 Yunsheng Lin wrote: > When user has configured a large number of virtual netdev, such > as 4K vlans, the carrier on/off operation of the real netdev > will also cause it's virtual netdev's link state to be processed > in linkwatch. Currently, the processing is

[PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-26 Thread Yunsheng Lin
When user has configured a large number of virtual netdev, such as 4K vlans, the carrier on/off operation of the real netdev will also cause it's virtual netdev's link state to be processed in linkwatch. Currently, the processing is done in a work queue, which may cause worker starvation problem