Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> > goto err; >> > >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Yunsheng Lin
Hi, Dan On 2017/10/27 19:52, Dan Carpenter wrote: > On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> Hi, Dan >> >> On 2017/10/27 14:40, Dan Carpenter wrote: >>> There are several places where we accidentally return success when >>> kcalloc() fails. >>> >>> Fixes: fcb39f6c10b2

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Yunsheng Lin
Hi, Dan On 2017/10/27 19:52, Dan Carpenter wrote: > On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> Hi, Dan >> >> On 2017/10/27 14:40, Dan Carpenter wrote: >>> There are several places where we accidentally return success when >>> kcalloc() fails. >>> >>> Fixes: fcb39f6c10b2

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Dan Carpenter
On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: > Hi, Dan > > On 2017/10/27 14:40, Dan Carpenter wrote: > > There are several places where we accidentally return success when > > kcalloc() fails. > > > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > >

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Dan Carpenter
On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: > Hi, Dan > > On 2017/10/27 14:40, Dan Carpenter wrote: > > There are several places where we accidentally return success when > > kcalloc() fails. > > > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > >

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Yunsheng Lin
Hi, Dan On 2017/10/27 14:40, Dan Carpenter wrote: > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan Carpenter

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Yunsheng Lin
Hi, Dan On 2017/10/27 14:40, Dan Carpenter wrote: > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan Carpenter > > diff --git

[PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Dan Carpenter
There are several places where we accidentally return success when kcalloc() fails. Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and processing mpa fpdus") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c

[PATCH net-next] qed: Set error code for allocation failures

2017-10-27 Thread Dan Carpenter
There are several places where we accidentally return success when kcalloc() fails. Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and processing mpa fpdus") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c