Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Michael S. Tsirkin
On Thu, Jan 16, 2014 at 02:03:38PM +0800, Jason Wang wrote: > On 01/16/2014 01:47 PM, Michael S. Tsirkin wrote: > >On Thu, Jan 16, 2014 at 12:29:35PM +0800, Jason Wang wrote: > >>On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: > >>>On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: >

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Jason Wang
On 01/16/2014 01:47 PM, Michael S. Tsirkin wrote: On Thu, Jan 16, 2014 at 12:29:35PM +0800, Jason Wang wrote: On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Michael S. Tsirkin
On Thu, Jan 16, 2014 at 12:29:35PM +0800, Jason Wang wrote: > On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: > >On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: > >>On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: > >>>On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: >

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Jason Wang
On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Jason Wang
On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Michael S. Tsirkin
On Thu, Jan 16, 2014 at 12:29:35PM +0800, Jason Wang wrote: On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: On 01/14/2014

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Jason Wang
On 01/16/2014 01:47 PM, Michael S. Tsirkin wrote: On Thu, Jan 16, 2014 at 12:29:35PM +0800, Jason Wang wrote: On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-15 Thread Michael S. Tsirkin
On Thu, Jan 16, 2014 at 02:03:38PM +0800, Jason Wang wrote: On 01/16/2014 01:47 PM, Michael S. Tsirkin wrote: On Thu, Jan 16, 2014 at 12:29:35PM +0800, Jason Wang wrote: On 01/15/2014 03:21 PM, Michael S. Tsirkin wrote: On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Michael S. Tsirkin
On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: > On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: > >> > On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: > >>> > > On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Jason Wang
On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: > On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: >> > On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: >>> > > On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: > >> We used to limit the number of packets queued through

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: > On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: > >> We used to limit the number of packets queued through tx_queue_length. This > >> has several issues: > >> > >> -

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Jason Wang
On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: > On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: >> We used to limit the number of packets queued through tx_queue_length. This >> has several issues: >> >> - tx_queue_length is the control of qdisc queue length, simply reusing it >>

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: > We used to limit the number of packets queued through tx_queue_length. This > has several issues: > > - tx_queue_length is the control of qdisc queue length, simply reusing it > to control the packets queued by device may cause

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: We used to limit the number of packets queued through tx_queue_length. This has several issues: - tx_queue_length is the control of qdisc queue length, simply reusing it to control the packets queued by device may cause confusion.

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Jason Wang
On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: We used to limit the number of packets queued through tx_queue_length. This has several issues: - tx_queue_length is the control of qdisc queue length, simply reusing it to control

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: We used to limit the number of packets queued through tx_queue_length. This has several issues: - tx_queue_length is

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Jason Wang
On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: We used to limit the number of packets queued through

Re: [PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-14 Thread Michael S. Tsirkin
On Wed, Jan 15, 2014 at 11:36:01AM +0800, Jason Wang wrote: On 01/14/2014 05:52 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 04:45:24PM +0800, Jason Wang wrote: On 01/14/2014 04:25 PM, Michael S. Tsirkin wrote: On Tue, Jan 14, 2014 at 02:53:07PM +0800, Jason Wang wrote: We

[PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-13 Thread Jason Wang
We used to limit the number of packets queued through tx_queue_length. This has several issues: - tx_queue_length is the control of qdisc queue length, simply reusing it to control the packets queued by device may cause confusion. - After commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523

[PATCH net-next] tun/macvtap: limit the packets queued through rcvbuf

2014-01-13 Thread Jason Wang
We used to limit the number of packets queued through tx_queue_length. This has several issues: - tx_queue_length is the control of qdisc queue length, simply reusing it to control the packets queued by device may cause confusion. - After commit 6acf54f1cf0a6747bac9fea26f34cfc5a9029523