Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Jason Wang
On 2018年03月01日 21:36, Michael S. Tsirkin wrote: On Thu, Mar 01, 2018 at 11:19:04AM +0800, Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Jason Wang
On 2018年03月01日 21:36, Michael S. Tsirkin wrote: On Thu, Mar 01, 2018 at 11:19:04AM +0800, Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Michael S. Tsirkin
On Thu, Mar 01, 2018 at 11:19:04AM +0800, Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Michael S. Tsirkin
On Thu, Mar 01, 2018 at 11:19:04AM +0800, Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Jason Wang
On 2018年03月01日 16:41, Jesper Dangaard Brouer wrote: On Thu, 1 Mar 2018 11:19:04 +0800 Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Jason Wang
On 2018年03月01日 16:41, Jesper Dangaard Brouer wrote: On Thu, 1 Mar 2018 11:19:04 +0800 Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Jesper Dangaard Brouer
On Thu, 1 Mar 2018 11:19:04 +0800 Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct >

Re: [PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-01 Thread Jesper Dangaard Brouer
On Thu, 1 Mar 2018 11:19:04 +0800 Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which breaks

[PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-02-28 Thread Jason Wang
XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom for struct skb_shared_info which breaks XDP assumption. Other complaints are, the complex linearize

[PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-02-28 Thread Jason Wang
XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom for struct skb_shared_info which breaks XDP assumption. Other complaints are, the complex linearize