Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:36, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > >> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >> * decrement it before returning. >>

Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:36, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > >> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >> * decrement it before returning. >>

Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:36, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > >> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >> * decrement it before returning. >>

Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Andrew Lunn
> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >* decrement it before returning. >*/ > of_node_put(child); > - > return of_mdiobus_register(bp->mii_bus, np); > }

[PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin Ciubotariu
The MACB embeds an MDIO bus controller. For this reason, the PHY nodes were represented as sub-nodes in the MACB node. Generally, the Ethernet controller is different than the MDIO controller, so the PHYs are probed by a separate MDIO driver. Since adding the PHY nodes directly under the ETH node