Re: [PATCH net-next v2 1/3] net: phy: dp83640: use new PTP_MSGTYPE_SYNC define

[Kurt Kanzenbach]

On Tue Nov 24 2020, Christian Eggers wrote:
> Replace use of magic number with recently introduced define.
>
> Signed-off-by: Christian Eggers 
> Cc: Kurt Kanzenbach 

Reviewed-by: Kurt Kanzenbach 


signature.asc
Description: PGP signature

[PATCH net-next v2 1/3] net: phy: dp83640: use new PTP_MSGTYPE_SYNC define

[Christian Eggers]

Replace use of magic number with recently introduced define.

Signed-off-by: Christian Eggers 
Cc: Kurt Kanzenbach 
---
 drivers/net/phy/dp83640.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index f2caccaf4408..9757ca0d9633 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -964,15 +964,12 @@ static void decode_status_frame(struct dp83640_private 
*dp83640,
 static int is_sync(struct sk_buff *skb, int type)
 {
struct ptp_header *hdr;
-   u8 msgtype;
 
hdr = ptp_parse_header(skb, type);
if (!hdr)
return 0;
 
-   msgtype = ptp_get_msgtype(hdr, type);
-
-   return (msgtype & 0xf) == 0;
+   return ptp_get_msgtype(hdr, type) == PTP_MSGTYPE_SYNC;
 }
 
 static void dp83640_free_clocks(void)
-- 
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: 
HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: 
HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; 
Markus Zeiler