Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-13 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Le 03/11/17 à 13:12, Vivien Didelot a écrit : >> Introduce a dsa_is_normal_port helper to check if a given port is a >> normal user port as opposed to a CPU port or DSA link. > > net/dsa/dsa2.c uses the "user" terminology should we

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-13 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Le 03/11/17 à 13:12, Vivien Didelot a écrit : >> Introduce a dsa_is_normal_port helper to check if a given port is a >> normal user port as opposed to a CPU port or DSA link. > > net/dsa/dsa2.c uses the "user" terminology should we use something like >

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-11 Thread Florian Fainelli
Le 03/11/17 à 13:12, Vivien Didelot a écrit : > Introduce a dsa_is_normal_port helper to check if a given port is a > normal user port as opposed to a CPU port or DSA link. net/dsa/dsa2.c uses the "user" terminology should we use something like that here? > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-11 Thread Florian Fainelli
Le 03/11/17 à 13:12, Vivien Didelot a écrit : > Introduce a dsa_is_normal_port helper to check if a given port is a > normal user port as opposed to a CPU port or DSA link. net/dsa/dsa2.c uses the "user" terminology should we use something like that here? > > Signed-off-by: Vivien Didelot >

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-11 Thread Andrew Lunn
On Sat, Mar 11, 2017 at 04:12:58PM -0500, Vivien Didelot wrote: > Introduce a dsa_is_normal_port helper to check if a given port is a > normal user port as opposed to a CPU port or DSA link. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-11 Thread Andrew Lunn
On Sat, Mar 11, 2017 at 04:12:58PM -0500, Vivien Didelot wrote: > Introduce a dsa_is_normal_port helper to check if a given port is a > normal user port as opposed to a CPU port or DSA link. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

[PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-11 Thread Vivien Didelot
Introduce a dsa_is_normal_port helper to check if a given port is a normal user port as opposed to a CPU port or DSA link. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/dsa.h

[PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper

2017-03-11 Thread Vivien Didelot
Introduce a dsa_is_normal_port helper to check if a given port is a normal user port as opposed to a CPU port or DSA link. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index