Re: [PATCH net-next v2 2/2] r8152: use eth_hw_addr_random

2014-09-03 Thread Bjørn Mork
Hayes Wang writes: > + ether_addr_copy(dev->perm_addr, dev->dev_addr); This isn't strictly necessary. register_netdev() will do it for you as long as you leave the default addr_assign_type (NET_ADDR_PERM). And you do. Bjørn -- To unsubscribe from this list: send the line

Re: [PATCH net-next v2 2/2] r8152: use eth_hw_addr_random

2014-09-03 Thread Bjørn Mork
Hayes Wang hayesw...@realtek.com writes: + ether_addr_copy(dev-perm_addr, dev-dev_addr); This isn't strictly necessary. register_netdev() will do it for you as long as you leave the default addr_assign_type (NET_ADDR_PERM). And you do. Bjørn -- To unsubscribe from this list:

[PATCH net-next v2 2/2] r8152: use eth_hw_addr_random

2014-09-02 Thread Hayes Wang
If the hw doesn't have a valid MAC address, give a random one and set it to the hw. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH net-next v2 2/2] r8152: use eth_hw_addr_random

2014-09-02 Thread Hayes Wang
If the hw doesn't have a valid MAC address, give a random one and set it to the hw. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/net/usb/r8152.c