Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Breno Leitao
On Wed, Feb 14, 2024 at 05:58:37PM +0100, Eric Dumazet wrote: > On Wed, Feb 14, 2024 at 5:49 PM Breno Leitao wrote: > > > > On Wed, Feb 14, 2024 at 04:41:36PM +0100, Eric Dumazet wrote: > > > On Wed, Feb 14, 2024 at 3:45 PM Breno Leitao wrote: > > > > > > > > On Tue, Feb 13, 2024 at 10:04:57AM

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Eric Dumazet
On Wed, Feb 14, 2024 at 5:49 PM Breno Leitao wrote: > > On Wed, Feb 14, 2024 at 04:41:36PM +0100, Eric Dumazet wrote: > > On Wed, Feb 14, 2024 at 3:45 PM Breno Leitao wrote: > > > > > > On Tue, Feb 13, 2024 at 10:04:57AM -0800, Jakub Kicinski wrote: > > > > On Tue, 13 Feb 2024 14:57:49 +0100

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Breno Leitao
On Wed, Feb 14, 2024 at 04:41:36PM +0100, Eric Dumazet wrote: > On Wed, Feb 14, 2024 at 3:45 PM Breno Leitao wrote: > > > > On Tue, Feb 13, 2024 at 10:04:57AM -0800, Jakub Kicinski wrote: > > > On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > > > > Please note that adding other sysfs

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Eric Dumazet
On Wed, Feb 14, 2024 at 3:45 PM Breno Leitao wrote: > > On Tue, Feb 13, 2024 at 10:04:57AM -0800, Jakub Kicinski wrote: > > On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > > > Please note that adding other sysfs entries is expensive for workloads > > > creating/deleting netdev and netns

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-14 Thread Breno Leitao
On Tue, Feb 13, 2024 at 10:04:57AM -0800, Jakub Kicinski wrote: > On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > > Please note that adding other sysfs entries is expensive for workloads > > creating/deleting netdev and netns often. > > > > I _think_ we should find a way for not creating

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-13 Thread Jakub Kicinski
On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > Please note that adding other sysfs entries is expensive for workloads > creating/deleting netdev and netns often. > > I _think_ we should find a way for not creating > /sys/class/net//queues/tx-{Q}/byte_queue_limits directory > and files

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-13 Thread Eric Dumazet
On Fri, Feb 2, 2024 at 5:55 PM Breno Leitao wrote: > > From: Jakub Kicinski > > softnet_data->time_squeeze is sometimes used as a proxy for > host overload or indication of scheduling problems. In practice > this statistic is very noisy and has hard to grasp units - > e.g. is 10 squeezes a

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-13 Thread Breno Leitao
On Tue, Feb 06, 2024 at 12:40:13PM +0100, Paolo Abeni wrote: > On Fri, 2024-02-02 at 08:53 -0800, Breno Leitao wrote: > > From: Jakub Kicinski > > > > softnet_data->time_squeeze is sometimes used as a proxy for > > host overload or indication of scheduling problems. In practice > > this

Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-06 Thread Paolo Abeni
On Fri, 2024-02-02 at 08:53 -0800, Breno Leitao wrote: > From: Jakub Kicinski > > softnet_data->time_squeeze is sometimes used as a proxy for > host overload or indication of scheduling problems. In practice > this statistic is very noisy and has hard to grasp units - > e.g. is 10 squeezes a

[PATCH net-next v3] net: dqs: add NIC stall detector based on BQL

2024-02-02 Thread Breno Leitao
From: Jakub Kicinski softnet_data->time_squeeze is sometimes used as a proxy for host overload or indication of scheduling problems. In practice this statistic is very noisy and has hard to grasp units - e.g. is 10 squeezes a second to be expected, or high? Delaying network (NAPI) processing