Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi David, Marcin, On Tue, 21 Feb 2017 11:16:02 -0500 David Miller wrote: > From: Jisheng Zhang > Date: Tue, 21 Feb 2017 12:37:40 +0800 > > > Thanks for your review. > > > > The measurement is simple: record how much time we spent in mvneta_rx_swbm() > > for receiving 1GB

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi David, Marcin, On Tue, 21 Feb 2017 11:16:02 -0500 David Miller wrote: > From: Jisheng Zhang > Date: Tue, 21 Feb 2017 12:37:40 +0800 > > > Thanks for your review. > > > > The measurement is simple: record how much time we spent in mvneta_rx_swbm() > > for receiving 1GB data, something as

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Jisheng, 2017-02-21 17:16 GMT+01:00 David Miller : > From: Jisheng Zhang > Date: Tue, 21 Feb 2017 12:37:40 +0800 > >> Thanks for your review. >> >> The measurement is simple: record how much time we spent in mvneta_rx_swbm() >> for receiving 1GB data,

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Jisheng, 2017-02-21 17:16 GMT+01:00 David Miller : > From: Jisheng Zhang > Date: Tue, 21 Feb 2017 12:37:40 +0800 > >> Thanks for your review. >> >> The measurement is simple: record how much time we spent in mvneta_rx_swbm() >> for receiving 1GB data, something as below: > > Please use a

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

From: Jisheng Zhang Date: Tue, 21 Feb 2017 12:37:40 +0800 > Thanks for your review. > > The measurement is simple: record how much time we spent in mvneta_rx_swbm() > for receiving 1GB data, something as below: Please use a standard tool for measuring performance, rather

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

From: Jisheng Zhang Date: Tue, 21 Feb 2017 12:37:40 +0800 > Thanks for your review. > > The measurement is simple: record how much time we spent in mvneta_rx_swbm() > for receiving 1GB data, something as below: Please use a standard tool for measuring performance, rather than profiling the

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Gregory, On Mon, 20 Feb 2017 15:21:35 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On lun., févr. 20 2017, Jisheng Zhang wrote: > > > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > > and tx_desc. These DMA descs are allocated by

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Gregory, On Mon, 20 Feb 2017 15:21:35 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On lun., févr. 20 2017, Jisheng Zhang wrote: > > > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > > and tx_desc. These DMA descs are allocated by dma_alloc_coherent, they > >

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Jisheng, On lun., févr. 20 2017, Jisheng Zhang wrote: > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > and tx_desc. These DMA descs are allocated by dma_alloc_coherent, they > are uncacheable if the device isn't cache coherent, reading from >

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Jisheng, On lun., févr. 20 2017, Jisheng Zhang wrote: > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > and tx_desc. These DMA descs are allocated by dma_alloc_coherent, they > are uncacheable if the device isn't cache coherent, reading from > uncached memory is

[PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc and tx_desc. These DMA descs are allocated by dma_alloc_coherent, they are uncacheable if the device isn't cache coherent, reading from uncached memory is fairly slow. patch1 reuses the read out status to getting status field

[PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc and tx_desc. These DMA descs are allocated by dma_alloc_coherent, they are uncacheable if the device isn't cache coherent, reading from uncached memory is fairly slow. patch1 reuses the read out status to getting status field