Re: [PATCH net 0/2] ipv6: fixes for the multicast routes
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 15 Jan 2021 19:42:07 +0100 you wrote: > From: Matteo Croce > > Fix two wrong flags in the IPv6 multicast routes created > by the autoconf code. > > Matteo Croce (2): > ipv6: create multicast route with RTPROT_KERNEL > ipv6: set multicast flag on the multicast route > > [...] Here is the summary with links: - [net,1/2] ipv6: create multicast route with RTPROT_KERNEL https://git.kernel.org/netdev/net/c/a826b04303a4 - [net,2/2] ipv6: set multicast flag on the multicast route https://git.kernel.org/netdev/net/c/ceed9038b278 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net 0/2] ipv6: fixes for the multicast routes
On Sat, Jan 16, 2021 at 5:41 AM David Ahern wrote:
>
> On 1/15/21 4:12 PM, Matteo Croce wrote:
> > On Fri, Jan 15, 2021 at 11:50 PM Jakub Kicinski wrote:
> >>
> >> On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote:
> >>> From: Matteo Croce
> >>>
> >>> Fix two wrong flags in the IPv6 multicast routes created
> >>> by the autoconf code.
> >>
> >> Any chance for Fixes tags here?
> >
> > Right.
> > For 1/2 I don't know exactly, that code was touched last time in
> > 86872cb57925 ("[IPv6] route: FIB6 configuration using struct
> > fib6_config"), but it was only refactored. Before 86872cb57925, it was
> > pushed in the git import commit by Linus: 1da177e4c3f4
> > ("Linux-2.6.12-rc2").
> > BTW, according the history repo, it entered the tree in the 2.4.0
> > import, so I'd say it's here since the beginning.
> >
> > While for 2/2 I'd say:
> >
> > Fixes: e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")
> >
>
> As I recall (memory jogging from commit description) my patch only moved
> the setting from ip6_route_info_create default to here.
>
> The change is correct, just thinking it goes back beyond 4.16. If
> someone has a system running a 4.14 or earlier kernel it should be easy
> to know if this was the default prior.
Indeed, it was the same long before 4.14:
# uname -a
Linux ubuntu 4.4.0-142-generic #168~14.04.1-Ubuntu SMP Sat Jan 19
11:26:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
# ip -6 -d route show table local dev eth0
unicast ff00::/8 proto boot scope global metric 256 pref medium
Regards,
--
per aspera ad upstream
Re: [PATCH net 0/2] ipv6: fixes for the multicast routes
On 1/15/21 4:12 PM, Matteo Croce wrote:
> On Fri, Jan 15, 2021 at 11:50 PM Jakub Kicinski wrote:
>>
>> On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote:
>>> From: Matteo Croce
>>>
>>> Fix two wrong flags in the IPv6 multicast routes created
>>> by the autoconf code.
>>
>> Any chance for Fixes tags here?
>
> Right.
> For 1/2 I don't know exactly, that code was touched last time in
> 86872cb57925 ("[IPv6] route: FIB6 configuration using struct
> fib6_config"), but it was only refactored. Before 86872cb57925, it was
> pushed in the git import commit by Linus: 1da177e4c3f4
> ("Linux-2.6.12-rc2").
> BTW, according the history repo, it entered the tree in the 2.4.0
> import, so I'd say it's here since the beginning.
>
> While for 2/2 I'd say:
>
> Fixes: e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")
>
As I recall (memory jogging from commit description) my patch only moved
the setting from ip6_route_info_create default to here.
The change is correct, just thinking it goes back beyond 4.16. If
someone has a system running a 4.14 or earlier kernel it should be easy
to know if this was the default prior.
Re: [PATCH net 0/2] ipv6: fixes for the multicast routes
On Fri, Jan 15, 2021 at 11:50 PM Jakub Kicinski wrote:
>
> On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote:
> > From: Matteo Croce
> >
> > Fix two wrong flags in the IPv6 multicast routes created
> > by the autoconf code.
>
> Any chance for Fixes tags here?
Right.
For 1/2 I don't know exactly, that code was touched last time in
86872cb57925 ("[IPv6] route: FIB6 configuration using struct
fib6_config"), but it was only refactored. Before 86872cb57925, it was
pushed in the git import commit by Linus: 1da177e4c3f4
("Linux-2.6.12-rc2").
BTW, according the history repo, it entered the tree in the 2.4.0
import, so I'd say it's here since the beginning.
While for 2/2 I'd say:
Fixes: e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")
--
per aspera ad upstream
Re: [PATCH net 0/2] ipv6: fixes for the multicast routes
On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote: > From: Matteo Croce > > Fix two wrong flags in the IPv6 multicast routes created > by the autoconf code. Any chance for Fixes tags here?
[PATCH net 0/2] ipv6: fixes for the multicast routes
From: Matteo Croce Fix two wrong flags in the IPv6 multicast routes created by the autoconf code. Matteo Croce (2): ipv6: create multicast route with RTPROT_KERNEL ipv6: set multicast flag on the multicast route net/ipv6/addrconf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.29.2
