Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread David Miller
From: Jason Wang Date: Mon, 5 Mar 2018 10:43:41 +0800 > > > On 2018年03月05日 07:38, David Miller wrote: >> From: Jason Wang >> Date: Fri, 2 Mar 2018 17:29:14 +0800 >> >>> XDP_REDIRECT support for mergeable buffer was removed since commit >>>

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread David Miller
From: Jason Wang Date: Mon, 5 Mar 2018 10:43:41 +0800 > > > On 2018年03月05日 07:38, David Miller wrote: >> From: Jason Wang >> Date: Fri, 2 Mar 2018 17:29:14 +0800 >> >>> XDP_REDIRECT support for mergeable buffer was removed since commit >>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread Jason Wang
On 2018年03月05日 07:38, David Miller wrote: From: Jason Wang Date: Fri, 2 Mar 2018 17:29:14 +0800 XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread Jason Wang
On 2018年03月05日 07:38, David Miller wrote: From: Jason Wang Date: Fri, 2 Mar 2018 17:29:14 +0800 XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread Jason Wang
On 2018年03月03日 01:36, Michael S. Tsirkin wrote: On Fri, Mar 02, 2018 at 05:29:14PM +0800, Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread Jason Wang
On 2018年03月03日 01:36, Michael S. Tsirkin wrote: On Fri, Mar 02, 2018 at 05:29:14PM +0800, Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread Jason Wang
On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote: On Fri, 2 Mar 2018 17:29:14 +0800 Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread Jason Wang
On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote: On Fri, 2 Mar 2018 17:29:14 +0800 Jason Wang wrote: XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread David Miller
From: Jason Wang Date: Fri, 2 Mar 2018 17:29:14 +0800 > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct >

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-04 Thread David Miller
From: Jason Wang Date: Fri, 2 Mar 2018 17:29:14 +0800 > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-02 Thread Michael S. Tsirkin
On Fri, Mar 02, 2018 at 05:29:14PM +0800, Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-02 Thread Michael S. Tsirkin
On Fri, Mar 02, 2018 at 05:29:14PM +0800, Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-02 Thread Jesper Dangaard Brouer
On Fri, 2 Mar 2018 17:29:14 +0800 Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct >

Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-02 Thread Jesper Dangaard Brouer
On Fri, 2 Mar 2018 17:29:14 +0800 Jason Wang wrote: > XDP_REDIRECT support for mergeable buffer was removed since commit > 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() > case"). This is because we don't reserve enough tailroom for struct > skb_shared_info which breaks

[PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-02 Thread Jason Wang
XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom for struct skb_shared_info which breaks XDP assumption. So this patch fixes this by reserving enough

[PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-03-02 Thread Jason Wang
XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom for struct skb_shared_info which breaks XDP assumption. So this patch fixes this by reserving enough