Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 19, 2015 at 01:54:17PM +0200, Lukas Wunner escreveu: > Hi Jiri, Hi David, > > On Fri, Jun 19, 2015 at 12:17:06AM +0200, Jiri Olsa wrote: > > it had effect.. prefix is passed to build framework throught > > .config-detected > > file as prefix_SQ variable, which is then referenced in

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-19 Thread Lukas Wunner
Hi Jiri, Hi David, On Fri, Jun 19, 2015 at 12:17:06AM +0200, Jiri Olsa wrote: > it had effect.. prefix is passed to build framework throught .config-detected > file as prefix_SQ variable, which is then referenced in perf Build makefiles You're right, thanks for the clarification. The underlying

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 19, 2015 at 01:54:17PM +0200, Lukas Wunner escreveu: Hi Jiri, Hi David, On Fri, Jun 19, 2015 at 12:17:06AM +0200, Jiri Olsa wrote: it had effect.. prefix is passed to build framework throught .config-detected file as prefix_SQ variable, which is then referenced in perf Build

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-19 Thread Lukas Wunner
Hi Jiri, Hi David, On Fri, Jun 19, 2015 at 12:17:06AM +0200, Jiri Olsa wrote: it had effect.. prefix is passed to build framework throught .config-detected file as prefix_SQ variable, which is then referenced in perf Build makefiles You're right, thanks for the clarification. The underlying

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 10:39:35PM +0200, Lukas Wunner wrote: > Hi David, > > On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote: > > It worked for me last week with OL6. > > I created a standalone perf rpm with 4.1-rc6; it builds just fine with > > _prefix (rpm variable) set to /usr: >

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread David Ahern
On 6/18/15 2:39 PM, Lukas Wunner wrote: So the prefix parameter should have no effect at all in your case, no matter to what you set it. It does: rpmbuild -bb --define="_prefix /tmp/junk" SPECS/perf.spec ... + make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: > Invoking Makefile.perf with prefix= breaks the build since Makefile.perf > hands that variable down to Makefile.build where it overrides > prefix := $(subst ./,,$(OUTPUT)$(dir)/) > > leading to errors like this: > No

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 10:39:35PM +0200, Lukas Wunner wrote: > Hi David, > > On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote: > > It worked for me last week with OL6. > > I created a standalone perf rpm with 4.1-rc6; it builds just fine with > > _prefix (rpm variable) set to /usr: >

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Lukas Wunner
Hi David, On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote: > It worked for me last week with OL6. > I created a standalone perf rpm with 4.1-rc6; it builds just fine with > _prefix (rpm variable) set to /usr: [...] > %global perf_make \ > make -s -C tools/perf V=1 WERROR=0

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread David Ahern
On 6/18/15 1:59 PM, Lukas Wunner wrote: E.g. the Debian "linux-tools" package makes use of that feature: MAKE_PERF := $(MAKE) prefix=/usr V=1 ARCH=$(KERNEL_ARCH_PERF) EXTRA_WARNINGS=-Wno-error Source:

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Lukas Wunner
Hi Jirka, On Thu, Jun 18, 2015 at 09:29:32PM +0200, Jiri Olsa wrote: > On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: > > Invoking Makefile.perf with prefix= breaks the build since Makefile.perf > > hands that variable down to Makefile.build where it overrides > > prefix

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: > Invoking Makefile.perf with prefix= breaks the build since Makefile.perf > hands that variable down to Makefile.build where it overrides > prefix := $(subst ./,,$(OUTPUT)$(dir)/) > > leading to errors like this: > No

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Lukas Wunner
Hi Jirka, On Thu, Jun 18, 2015 at 09:29:32PM +0200, Jiri Olsa wrote: On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: Invoking Makefile.perf with prefix= breaks the build since Makefile.perf hands that variable down to Makefile.build where it overrides prefix :=

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread David Ahern
On 6/18/15 1:59 PM, Lukas Wunner wrote: E.g. the Debian linux-tools package makes use of that feature: MAKE_PERF := $(MAKE) prefix=/usr V=1 ARCH=$(KERNEL_ARCH_PERF) EXTRA_WARNINGS=-Wno-error Source:

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Lukas Wunner
Hi David, On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote: It worked for me last week with OL6. I created a standalone perf rpm with 4.1-rc6; it builds just fine with _prefix (rpm variable) set to /usr: [...] %global perf_make \ make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: Invoking Makefile.perf with prefix= breaks the build since Makefile.perf hands that variable down to Makefile.build where it overrides prefix := $(subst ./,,$(OUTPUT)$(dir)/) leading to errors like this: No rule to

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 10:39:35PM +0200, Lukas Wunner wrote: Hi David, On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote: It worked for me last week with OL6. I created a standalone perf rpm with 4.1-rc6; it builds just fine with _prefix (rpm variable) set to /usr: [...]

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: Invoking Makefile.perf with prefix= breaks the build since Makefile.perf hands that variable down to Makefile.build where it overrides prefix := $(subst ./,,$(OUTPUT)$(dir)/) leading to errors like this: No rule to

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread David Ahern
On 6/18/15 2:39 PM, Lukas Wunner wrote: So the prefix parameter should have no effect at all in your case, no matter to what you set it. It does: rpmbuild -bb --define=_prefix /tmp/junk SPECS/perf.spec ... + make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1

Re: [PATCH regression 4.0 - 4.1] tools perf: Fix build breakage if prefix= is specified

2015-06-18 Thread Jiri Olsa
On Thu, Jun 18, 2015 at 10:39:35PM +0200, Lukas Wunner wrote: Hi David, On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote: It worked for me last week with OL6. I created a standalone perf rpm with 4.1-rc6; it builds just fine with _prefix (rpm variable) set to /usr: [...]