Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-05 Thread Eric W. Biederman
"J. Bruce Fields" writes: > On Mon, Mar 04, 2013 at 09:11:16AM -0800, Eric W. Biederman wrote: >> "J. Bruce Fields" writes: >> >> Not strongly. As long as we have the uid ang gid valid checks in >> there somewhere before we start using these uids and gids much. >> This does seems to be the

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-05 Thread J. Bruce Fields
On Mon, Mar 04, 2013 at 09:11:16AM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > > krb5 mounts started failing for me as of this patch (upstream as > > 683428fae8c73d7d7da0fa2e0b6beb4d8df4e808), > > Ouch! > > > and I believe the problem is > > these uid/gid_valid checks:

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-05 Thread J. Bruce Fields
On Mon, Mar 04, 2013 at 09:11:16AM -0800, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: krb5 mounts started failing for me as of this patch (upstream as 683428fae8c73d7d7da0fa2e0b6beb4d8df4e808), Ouch! and I believe the problem is these uid/gid_valid

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-05 Thread Eric W. Biederman
J. Bruce Fields bfie...@fieldses.org writes: On Mon, Mar 04, 2013 at 09:11:16AM -0800, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: Not strongly. As long as we have the uid ang gid valid checks in there somewhere before we start using these uids and gids much.

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-04 Thread Eric W. Biederman
"J. Bruce Fields" writes: > krb5 mounts started failing for me as of this patch (upstream as > 683428fae8c73d7d7da0fa2e0b6beb4d8df4e808), Ouch! > and I believe the problem is > these uid/gid_valid checks: if I recall correctly, gssd uses -1 uid/gid > values to indicate "authentication

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-04 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 09:51:38AM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > For each received uid call make_kuid and validate the result. > For each received gid call make_kgid and validate the result. > > Cc: "J. Bruce Fields" > Cc: Trond Myklebust > Signed-off-by:

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-04 Thread J. Bruce Fields
On Wed, Feb 13, 2013 at 09:51:38AM -0800, Eric W. Biederman wrote: From: Eric W. Biederman ebied...@xmission.com For each received uid call make_kuid and validate the result. For each received gid call make_kgid and validate the result. Cc: J. Bruce Fields bfie...@fieldses.org Cc: Trond

Re: [PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-03-04 Thread Eric W. Biederman
J. Bruce Fields bfie...@fieldses.org writes: krb5 mounts started failing for me as of this patch (upstream as 683428fae8c73d7d7da0fa2e0b6beb4d8df4e808), Ouch! and I believe the problem is these uid/gid_valid checks: if I recall correctly, gssd uses -1 uid/gid values to indicate

[PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-02-13 Thread Eric W. Biederman
From: "Eric W. Biederman" For each received uid call make_kuid and validate the result. For each received gid call make_kgid and validate the result. Cc: "J. Bruce Fields" Cc: Trond Myklebust Signed-off-by: "Eric W. Biederman" --- net/sunrpc/auth_gss/svcauth_gss.c | 18 +-

[PATCH review 49/85] sunrpc: Update svcgss xdr handle to rpsec_contect cache

2013-02-13 Thread Eric W. Biederman
From: Eric W. Biederman ebied...@xmission.com For each received uid call make_kuid and validate the result. For each received gid call make_kgid and validate the result. Cc: J. Bruce Fields bfie...@fieldses.org Cc: Trond Myklebust trond.mykleb...@netapp.com Signed-off-by: Eric W. Biederman