Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-23 Thread Levin, Alexander (Sasha Levin)
On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote: >On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote: >> From: Jan Beulich >> >> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] >> >> A negative return value indicates an error; in fact the

Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-23 Thread Levin, Alexander (Sasha Levin)
On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote: >On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote: >> From: Jan Beulich >> >> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] >> >> A negative return value indicates an error; in fact the function at >>

Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-10 Thread Boris Ostrovsky
On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote: > From: Jan Beulich > > [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] > > A negative return value indicates an error; in fact the function at > present won't ever return zero. > > Signed-off-by: Jan

Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-10 Thread Boris Ostrovsky
On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote: > From: Jan Beulich > > [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] > > A negative return value indicates an error; in fact the function at > present won't ever return zero. > > Signed-off-by: Jan Beulich >

[PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Jan Beulich [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] A negative return value indicates an error; in fact the function at present won't ever return zero. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross

[PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Jan Beulich [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ] A negative return value indicates an error; in fact the function at present won't ever return zero. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Signed-off-by: Boris Ostrovsky Signed-off-by: Sasha Levin