Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 05:35:17PM +0200, Michal Hocko wrote: > Updated patch Thanks for this, and the updated patch series, I've now replaced the previous versions with this series. greg k-h

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 05:35:17PM +0200, Michal Hocko wrote: > Updated patch Thanks for this, and the updated patch series, I've now replaced the previous versions with this series. greg k-h

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

Updated patch --- >From ac6657609db69a5a591b96a4b0fd18140408f41e Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Wed, 20 Jul 2016 15:44:57 -0700 Subject: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs commit

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

Updated patch --- >From ac6657609db69a5a591b96a4b0fd18140408f41e Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Wed, 20 Jul 2016 15:44:57 -0700 Subject: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. The

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 17:22:36, Greg KH wrote: > On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: [...] > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index 3c6a86b4ec25..312ef6f7b7b1 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -522,7 +522,7 @@ void

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 17:22:36, Greg KH wrote: > On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: [...] > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index 3c6a86b4ec25..312ef6f7b7b1 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -522,7 +522,7 @@ void

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 11:16:04, Johannes Weiner wrote: > On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: > > @@ -4173,11 +4213,17 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > > > memcg->stat = alloc_percpu(struct mem_cgroup_stat_cpu); > > if (!memcg->stat) > > -

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 11:16:04, Johannes Weiner wrote: > On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: > > @@ -4173,11 +4213,17 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > > > memcg->stat = alloc_percpu(struct mem_cgroup_stat_cpu); > > if (!memcg->stat) > > -

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: > From: Johannes Weiner > > commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. > > The memory controller has quite a bit of state that usually outlives the > cgroup and pins its CSS until said state

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: > From: Johannes Weiner > > commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. > > The memory controller has quite a bit of state that usually outlives the > cgroup and pins its CSS until said state disappears. At the same

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: > @@ -4173,11 +4213,17 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > memcg->stat = alloc_percpu(struct mem_cgroup_stat_cpu); > if (!memcg->stat) > - goto out_free; > + goto out_idr;

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 05:06:44PM +0200, Michal Hocko wrote: > @@ -4173,11 +4213,17 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > memcg->stat = alloc_percpu(struct mem_cgroup_stat_cpu); > if (!memcg->stat) > - goto out_free; > + goto out_idr;

[PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

From: Johannes Weiner commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. The memory controller has quite a bit of state that usually outlives the cgroup and pins its CSS until said state disappears. At the same time it imposes a 16-bit limit on the CSS ID space to

[PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

From: Johannes Weiner commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. The memory controller has quite a bit of state that usually outlives the cgroup and pins its CSS until said state disappears. At the same time it imposes a 16-bit limit on the CSS ID space to economically store IDs

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 04:04:39PM +0200, Michal Hocko wrote: > On Mon 15-08-16 09:37:48, Johannes Weiner wrote: > > On Mon, Aug 15, 2016 at 02:46:19PM +0200, Michal Hocko wrote: > > > On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > > > > Hi Michal, thanks for doing this. There is only one

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 04:04:39PM +0200, Michal Hocko wrote: > On Mon 15-08-16 09:37:48, Johannes Weiner wrote: > > On Mon, Aug 15, 2016 at 02:46:19PM +0200, Michal Hocko wrote: > > > On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > > > > Hi Michal, thanks for doing this. There is only one

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 09:37:48, Johannes Weiner wrote: > On Mon, Aug 15, 2016 at 02:46:19PM +0200, Michal Hocko wrote: > > On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > > > Hi Michal, thanks for doing this. There is only one issue I can see: > > > > > > On Fri, Aug 12, 2016 at 11:56:17AM +0200,

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 09:37:48, Johannes Weiner wrote: > On Mon, Aug 15, 2016 at 02:46:19PM +0200, Michal Hocko wrote: > > On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > > > Hi Michal, thanks for doing this. There is only one issue I can see: > > > > > > On Fri, Aug 12, 2016 at 11:56:17AM +0200,

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 02:46:19PM +0200, Michal Hocko wrote: > On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > > Hi Michal, thanks for doing this. There is only one issue I can see: > > > > On Fri, Aug 12, 2016 at 11:56:17AM +0200, Michal Hocko wrote: > > > @@ -4171,17 +4211,27 @@ static

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon, Aug 15, 2016 at 02:46:19PM +0200, Michal Hocko wrote: > On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > > Hi Michal, thanks for doing this. There is only one issue I can see: > > > > On Fri, Aug 12, 2016 at 11:56:17AM +0200, Michal Hocko wrote: > > > @@ -4171,17 +4211,27 @@ static

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > Hi Michal, thanks for doing this. There is only one issue I can see: > > On Fri, Aug 12, 2016 at 11:56:17AM +0200, Michal Hocko wrote: > > @@ -4171,17 +4211,27 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > if (!memcg) > >

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

On Mon 15-08-16 08:34:07, Johannes Weiner wrote: > Hi Michal, thanks for doing this. There is only one issue I can see: > > On Fri, Aug 12, 2016 at 11:56:17AM +0200, Michal Hocko wrote: > > @@ -4171,17 +4211,27 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > if (!memcg) > >

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

Hi Michal, thanks for doing this. There is only one issue I can see: On Fri, Aug 12, 2016 at 11:56:17AM +0200, Michal Hocko wrote: > @@ -4171,17 +4211,27 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > if (!memcg) > return NULL; > > + memcg->id.id =

Re: [PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

Hi Michal, thanks for doing this. There is only one issue I can see: On Fri, Aug 12, 2016 at 11:56:17AM +0200, Michal Hocko wrote: > @@ -4171,17 +4211,27 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > if (!memcg) > return NULL; > > + memcg->id.id =

[PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

From: Johannes Weiner commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. The memory controller has quite a bit of state that usually outlives the cgroup and pins its CSS until said state disappears. At the same time it imposes a 16-bit limit on the CSS ID space to

[PATCH stable-4.4 1/3] mm: memcontrol: fix cgroup creation failure after many small jobs

From: Johannes Weiner commit 73f576c04b9410ed19660f74f97521bee6e1c546 upstream. The memory controller has quite a bit of state that usually outlives the cgroup and pins its CSS until said state disappears. At the same time it imposes a 16-bit limit on the CSS ID space to economically store IDs