Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-30 Thread Paul E. McKenney
On Thu, Aug 30, 2018 at 01:40:12PM -0400, Steven Rostedt wrote: > On Thu, 30 Aug 2018 10:10:06 -0700 > "Paul E. McKenney" wrote: > > > > > I would just keep the documentation patches separate. > > > > Combining yours and Josh's feedback, I will split the documentation > > updates out of 4ca05

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-30 Thread Steven Rostedt
On Thu, 30 Aug 2018 10:10:06 -0700 "Paul E. McKenney" wrote: > > I would just keep the documentation patches separate. > > Combining yours and Josh's feedback, I will split the documentation > updates out of 4ca0508f7870 ("rcu: Remove rsp parameter from rcu_node tree > accessor macros") and p

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-30 Thread Paul E. McKenney
On Thu, Aug 30, 2018 at 11:44:52AM -0400, Steven Rostedt wrote: > On Wed, 29 Aug 2018 21:10:17 -0700 > "Paul E. McKenney" wrote: > > > On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote: > > > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > > > > On Wed, 29 Aug 2

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-30 Thread Steven Rostedt
On Wed, 29 Aug 2018 21:10:17 -0700 "Paul E. McKenney" wrote: > On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote: > > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > > > On Wed, 29 Aug 2018 15:38:30 -0700 > > > "Paul E. McKenney" wrote: > > > > > > > Hello!

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-30 Thread Steven Rostedt
On Wed, 29 Aug 2018 21:20:07 -0700 Josh Triplett wrote: > > And please see below for what the resulting diff would look like. Is > > this an improvement? > > Honestly, as long as the result after each commit compiles, I prefer the > split version for ease of review. You and I have different

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-29 Thread Josh Triplett
On Wed, Aug 29, 2018 at 09:10:17PM -0700, Paul E. McKenney wrote: > On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote: > > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > > > On Wed, 29 Aug 2018 15:38:30 -0700 > > > "Paul E. McKenney" wrote: > > > > > > > Hello! >

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-29 Thread Paul E. McKenney
On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote: > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > > On Wed, 29 Aug 2018 15:38:30 -0700 > > "Paul E. McKenney" wrote: > > > > > Hello! > > > > > > This commit does RCU-consolidation cleanups that get rid of pointe

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-29 Thread Paul E. McKenney
On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > On Wed, 29 Aug 2018 15:38:30 -0700 > "Paul E. McKenney" wrote: > > > Hello! > > > > This commit does RCU-consolidation cleanups that get rid of pointers to > > the sole remaining rcu_state structure: > > > > 1-40: Remove th

Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-29 Thread Steven Rostedt
On Wed, 29 Aug 2018 15:38:30 -0700 "Paul E. McKenney" wrote: > Hello! > > This commit does RCU-consolidation cleanups that get rid of pointers to > the sole remaining rcu_state structure: > > 1-40: Remove the "rsp" parameter from numerous functions, given that > the corresponding argument

[PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

2018-08-29 Thread Paul E. McKenney
Hello! This commit does RCU-consolidation cleanups that get rid of pointers to the sole remaining rcu_state structure: 1-40: Remove the "rsp" parameter from numerous functions, given that the corresponding argument will always be &rcu_state. 41. Remove rcu_data structure's ->rsp fi