On 10/12/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote:
> On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote:
> >
> > > Isn't disabling device interrupts from the begining of the ISR
> > > "ad7142_interrupt"
> > > till the kthread "ad7142_thread" got waked-up and scheduled a long
On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote:
> Hi Ahmed,
>
Hi :),
> On 10/12/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote:
> > On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
> > >
> > > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> > > ---
> >
> > Hi Bryan,
> >
Hi Ahmed,
On 10/12/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote:
> On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
> >
> > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> > ---
>
> Hi Bryan,
>
> Why creating module's own kthread to call ad7142_decode and process keycodes
> instead of
On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
>
> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> ---
Hi Bryan,
Why creating module's own kthread to call ad7142_decode and process keycodes
instead of using a tasklet ?
Isn't disabling device interrupts from the begining of the ISR
On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote:
> > On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> > > On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
> > > > Hi Bryan,
> > > >
> > > > On 10/12/07, Bryan Wu <[EMAIL
On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote:
> On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> > On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
> > > Hi Bryan,
> > >
> > > On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> > > > +
> > [snip]
> > > > +
> > > > +static
On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
> > Hi Bryan,
> >
> > On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> > > +
> [snip]
> > > +
> > > +static void ad7142_close(struct input_dev *dev)
> > > +{
> > > +
On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
> Hi Bryan,
>
> On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> > +
[snip]
> > +
> > +static void ad7142_close(struct input_dev *dev)
> > +{
> > + free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX, ad7142_interrupt);
> > +
Hi Bryan,
On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote:
> +
> +static int
> +ad7142_probe(struct i2c_adapter *adap, int addr, int kind)
> +{
> + struct i2c_client *client;
> + int rc;
> +
> + client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
> + if (!client)
> +
Bryan Wu wrote:
> +static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset,
> + unsigned short *data, unsigned int len)
> +{
> + int ret = -1;
> + int i;
> + u8 block_data[32];
> +
> + if (len < 1 && len > 16) {
you want || here
> +
On 285, 10 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
> Subject: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick
> driver
>
> [try #2] Changelog:
> - Coding style issues fixed, passed checkpatch.pl
> - Kill uselss "ad7142_used"
> - Move
Subject: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick
driver
[try #2] Changelog:
- Coding style issues fixed, passed checkpatch.pl
- Kill uselss "ad7142_used"
- Move request_irq to probe
- Move i2c_check_functionality to probe
- Error handling added
Subject: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick
driver
[try #2] Changelog:
- Coding style issues fixed, passed checkpatch.pl
- Kill uselss ad7142_used
- Move request_irq to probe
- Move i2c_check_functionality to probe
- Error handling added
Signed-off-by: Bryan
On 285, 10 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
Subject: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick
driver
[try #2] Changelog:
- Coding style issues fixed, passed checkpatch.pl
- Kill uselss ad7142_used
- Move request_irq to probe
- Move
Bryan Wu wrote:
+static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset,
+ unsigned short *data, unsigned int len)
+{
+ int ret = -1;
+ int i;
+ u8 block_data[32];
+
+ if (len 1 len 16) {
you want || here
+ printk(KERN_ERR
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
Hi Bryan,
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
+
[snip]
+
+static void ad7142_close(struct input_dev *dev)
+{
+ free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX,
On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
Hi Bryan,
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
+
[snip]
+
+static void ad7142_close(struct input_dev *dev)
+{
+ free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX, ad7142_interrupt);
+ kthread_stop(ad7142_task);
Hi Bryan,
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
+
+static int
+ad7142_probe(struct i2c_adapter *adap, int addr, int kind)
+{
+ struct i2c_client *client;
+ int rc;
+
+ client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+ if (!client)
+
Hi Ahmed,
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote:
On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
Hi Bryan,
Why creating module's own kthread to call ad7142_decode and process keycodes
instead of using a tasklet ?
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote:
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
Hi Bryan,
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
+
On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote:
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote:
Hi Bryan,
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote:
+
[snip]
+
+static void ad7142_close(struct
On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote:
Hi Ahmed,
Hi :),
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote:
On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
Hi Bryan,
Why creating module's
On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
Hi Bryan,
Why creating module's own kthread to call ad7142_decode and process keycodes
instead of using a tasklet ?
Isn't disabling device interrupts from the begining of the ISR
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote:
On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote:
Isn't disabling device interrupts from the begining of the ISR
ad7142_interrupt
till the kthread ad7142_thread got waked-up and scheduled a long time,
espicially
24 matches
Mail list logo
