Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Ian Kent
On Tue, 2018-07-03 at 07:48 +0200, Dmitry Vyukov wrote: > On Tue, Jul 3, 2018 at 3:34 AM, Ian Kent wrote: > > On Mon, 2018-07-02 at 14:15 +0200, Dmitry Vyukov wrote: > > > On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote: > > > > Yes, thanks. Please use my full name, Tomas Bortoli. > > > > > > > > >

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Dmitry Vyukov
On Tue, Jul 3, 2018 at 3:34 AM, Ian Kent wrote: > On Mon, 2018-07-02 at 14:15 +0200, Dmitry Vyukov wrote: >> On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote: >> > Yes, thanks. Please use my full name, Tomas Bortoli. >> >> >> Please also include: >> >> Reported-by: syzbot+60c837b428dc84e83...@syzkalle

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Ian Kent
On Mon, 2018-07-02 at 14:15 +0200, Dmitry Vyukov wrote: > On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote: > > Yes, thanks. Please use my full name, Tomas Bortoli. > > > Please also include: > > Reported-by: syzbot+60c837b428dc84e83...@syzkaller.appspotmail.com Done. > > from the original bug re

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Dmitry Vyukov
On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote: > Yes, thanks. Please use my full name, Tomas Bortoli. Please also include: Reported-by: syzbot+60c837b428dc84e83...@syzkaller.appspotmail.com from the original bug report. This this help to keep automatic testing process running. Thanks > > On 0

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread tomas
Yes, thanks. Please use my full name, Tomas Bortoli. Cheers On 07/02/2018 12:20 PM, Ian Kent wrote: > On Mon, 2018-07-02 at 10:31 +0200, tomas wrote: >> Hi Ian, >> >> you are welcome! >> >> yes your patch is much better. You should just put the "_IOC_NR" macro >> around "cmd" in the lines added

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Ian Kent
On Mon, 2018-07-02 at 10:31 +0200, tomas wrote: > Hi Ian, > > you are welcome! > > yes your patch is much better. You should just put the "_IOC_NR" macro > around "cmd" in the lines added to "validate_dev_ioctl" to make it work. LOL, yes, that was a dumb mistake. I'll send it to Andrew Morton,

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread tomas
Hi Ian, you are welcome! yes your patch is much better. You should just put the "_IOC_NR" macro around "cmd" in the lines added to "validate_dev_ioctl" to make it work. Tomas On 07/02/2018 03:42 AM, Ian Kent wrote: > On Mon, 2018-07-02 at 09:10 +0800, Ian Kent wrote: >> On Mon, 2018-07-02 at 0

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-01 Thread Ian Kent
On Mon, 2018-07-02 at 09:10 +0800, Ian Kent wrote: > On Mon, 2018-07-02 at 00:04 +0200, tomas wrote: > > Hi, > > > > I've looked into this issue found by Syzbot and I made a patch: > > > > https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f97208ae425b116 > > 3 > > Umm ... oops! > > T

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-01 Thread Ian Kent
On Mon, 2018-07-02 at 00:04 +0200, tomas wrote: > Hi, > > I've looked into this issue found by Syzbot and I made a patch: > > https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f97208ae425b1163 Umm ... oops! Thanks for looking into this Tomas. > > > The autofs subsystem does not ch

[PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-01 Thread tomas
Hi, I've looked into this issue found by Syzbot and I made a patch: https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f97208ae425b1163 The autofs subsystem does not check that the "path" parameter is present within the "param" struct passed by the userspace in case the AUTOFS_DEV_IOC