Re: [PATCH v1] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
hi Krzysztof,
On Tue, 26 Mar 2019 at 16:28, Krzysztof Kozlowski wrote:
>
> On Tue, 26 Mar 2019 at 11:35, Anand Moon wrote:
>
> (...)
>
> > > This is third or fourth submission but you marked it as v1. This makes
> > > it very difficult to discuss and reference previous versions.
> > >
> > > The commit message did not change since beginning (first version). I
> > > asked twice that you need to explain exactly why you put the the
> > > regulator to off or on state in suspend. Why?
> > > Because:
> > > 1. This change looks without justification - once you put on, then you
> > > put off, now again on,
> > > 2. Anyone reading the code later must know the rationale why this was
> > > done,
> > > 3. I am not quite sure whether this is good setting so I would be
> > > happy to be convinced.
> > >
> >
> > Like I mention in the patch summary that this.
> >
> > Current changes are based on
> > [0]
> > https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
> >
> > Regulators which can be turned off during system suspend:
> > -LDOn : 2, 6-8, 10-12, 14-16,
> > -BUCKn : 1-4.
> > Use standard regulator bindings for it ('regulator-off-in-suspend').
>
> I do not see how this is related to my questions.
>
> > > How to provide such explanation? The best in commit message. Sometimes
> > > in the comment in the code, depends.
> >
> > Ok I have been testing with following regulator debug prints to catch error.
> > [0] max77686-regulator.patch
> >
> > below is the console logs during suspend and resume.
> > ---
> > Last login: Sat Mar 23 18:22:46 on ttySAC1
> > [root@archl-u3e ~]# echo no > /sys/module/printk/parameters/console_suspend
> > [root@archl-u3e ~]# rtcwake -d /dev/rtc0 -m mem -s 10
> > rtcwake: wakeup from "mem" using /dev/rtc0 at Sat Mar 23 19:56:17 2019
> > [ 38.595854] PM: suspend entry (deep)
> > [ 38.596603] PM: Syncing filesystems ... done.
> > [ 38.629351] Freezing user space processes ... (elapsed 0.002 seconds)
> > done.
> > [ 38.633192] OOM killer disabled.
> > [ 38.636035] Freezing remaining freezable tasks ... (elapsed 0.001
> > seconds) done.
> > [ 38.675059] smsc95xx 1-2:1.0 eth0: entering SUSPEND2 mode
> > [ 38.753120] dwc2 1248.hsotg: suspending usb gadget g_ether
> > [ 38.754007] dwc2 1248.hsotg: new device is full-speed
> > [ 38.758960] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
> > [ 38.765507] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
> > [ 38.774050] wake enabled for irq 119
> > [ 38.775761] BUCK9: No configuration
> > [ 38.779191] BUCK8_P3V3: No configuration
> > [ 38.782852] BUCK7_2.0V: No configuration
> > [ 38.786851] BUCK6_1.35V: No configuration
> > [ 38.790752] VDDQ_CKEM1_2_1.2V: No configuration
> > [ 38.796220] BUCK4: regulator suspend disable supported
> > [ 38.800769] BUCK3: regulator suspend disable supported
> > [ 38.806002] BUCK1: regulator suspend disable supported
> > [ 38.810644] LDO26: No configuration
> > [ 38.814169] VDDQ_LCD_1.8V: No configuration
> > [ 38.818267] LDO24: No configuration
> > [ 38.821732] LDO23: No configuration
> > [ 38.825262] LDO22_VDDQ_MMC4_2.8V: No configuration
> > [ 38.829992] TFLASH_2.8V: No configuration
> > [ 38.834040] LDO20_1.8V: No configuration
> > [ 38.837883] LDO19: No configuration
> > [ 38.841349] LDO18: No configuration
> > [ 38.844878] LDO17: No configuration
> > [ 38.848667] LDO16: regulator suspend disable supported
> > [ 38.853889] LDO15: regulator suspend disable supported
> > [ 38.858931] LDO14: regulator suspend disable supported
> > [ 38.863771] VDDQ_C2C_W_1.8V: No configuration
> > [ 38.868378] LDO12: regulator suspend disable supported
> > [ 38.873508] LDO11: regulator suspend disable supported
> > [ 38.878545] LDO10: regulator suspend disable supported
> > [ 38.883384] LDO9: No configuration
> > [ 38.887190] LDO8: regulator suspend disable supported
> > [ 38.892168] LDO7: regulator suspend disable supported
> > [ 38.897279] LDO6: regulator suspend disable supported
> > [ 38.901872] VDDQ_MMC1_3_1.8V: No configuration
> > [ 38.906363] VDDQ_MMC2_2.8V: No configuration
> > [ 38.910541] VDDQ_EXT_1.8V: No configuration
> > [ 38.915134] LDO2: regulator suspend disable supported
> > [ 38.919753] VDD_ALIVE_1.0V: No configuration
> > [ 38.935229] usb3503 0-0008: switched to STANDBY mode
> > [ 38.935981] wake enabled for irq 123
> > [ 38.955192] samsung-pinctrl 1100.pinctrl: Setting external
> > wakeup interrupt mask: 0xfbfff7ff
> > [ 38.975448] Disabling non-boot CPUs ...
> > [ 39.029279] s3c2410-wdt 1006.watchdog: watchdog disabled
> > [ 39.029576] wake disabled for irq 123
> > [ 39.044319] usb3503 0-0008: switched to HUB mode
> > [ 39.144089] wake disabled for irq 119
> > [ 39.144812] dwc2 1248.hsotg: resuming usb gadget g_ether
> > [ 39.422626] usb 1-2: reset
Re: [PATCH v1] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
On Tue, 26 Mar 2019 at 11:35, Anand Moon wrote:
(...)
> > This is third or fourth submission but you marked it as v1. This makes
> > it very difficult to discuss and reference previous versions.
> >
> > The commit message did not change since beginning (first version). I
> > asked twice that you need to explain exactly why you put the the
> > regulator to off or on state in suspend. Why?
> > Because:
> > 1. This change looks without justification - once you put on, then you
> > put off, now again on,
> > 2. Anyone reading the code later must know the rationale why this was done,
> > 3. I am not quite sure whether this is good setting so I would be
> > happy to be convinced.
> >
>
> Like I mention in the patch summary that this.
>
> Current changes are based on
> [0]
> https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
>
> Regulators which can be turned off during system suspend:
> -LDOn : 2, 6-8, 10-12, 14-16,
> -BUCKn : 1-4.
> Use standard regulator bindings for it ('regulator-off-in-suspend').
I do not see how this is related to my questions.
> > How to provide such explanation? The best in commit message. Sometimes
> > in the comment in the code, depends.
>
> Ok I have been testing with following regulator debug prints to catch error.
> [0] max77686-regulator.patch
>
> below is the console logs during suspend and resume.
> ---
> Last login: Sat Mar 23 18:22:46 on ttySAC1
> [root@archl-u3e ~]# echo no > /sys/module/printk/parameters/console_suspend
> [root@archl-u3e ~]# rtcwake -d /dev/rtc0 -m mem -s 10
> rtcwake: wakeup from "mem" using /dev/rtc0 at Sat Mar 23 19:56:17 2019
> [ 38.595854] PM: suspend entry (deep)
> [ 38.596603] PM: Syncing filesystems ... done.
> [ 38.629351] Freezing user space processes ... (elapsed 0.002 seconds) done.
> [ 38.633192] OOM killer disabled.
> [ 38.636035] Freezing remaining freezable tasks ... (elapsed 0.001
> seconds) done.
> [ 38.675059] smsc95xx 1-2:1.0 eth0: entering SUSPEND2 mode
> [ 38.753120] dwc2 1248.hsotg: suspending usb gadget g_ether
> [ 38.754007] dwc2 1248.hsotg: new device is full-speed
> [ 38.758960] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
> [ 38.765507] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
> [ 38.774050] wake enabled for irq 119
> [ 38.775761] BUCK9: No configuration
> [ 38.779191] BUCK8_P3V3: No configuration
> [ 38.782852] BUCK7_2.0V: No configuration
> [ 38.786851] BUCK6_1.35V: No configuration
> [ 38.790752] VDDQ_CKEM1_2_1.2V: No configuration
> [ 38.796220] BUCK4: regulator suspend disable supported
> [ 38.800769] BUCK3: regulator suspend disable supported
> [ 38.806002] BUCK1: regulator suspend disable supported
> [ 38.810644] LDO26: No configuration
> [ 38.814169] VDDQ_LCD_1.8V: No configuration
> [ 38.818267] LDO24: No configuration
> [ 38.821732] LDO23: No configuration
> [ 38.825262] LDO22_VDDQ_MMC4_2.8V: No configuration
> [ 38.829992] TFLASH_2.8V: No configuration
> [ 38.834040] LDO20_1.8V: No configuration
> [ 38.837883] LDO19: No configuration
> [ 38.841349] LDO18: No configuration
> [ 38.844878] LDO17: No configuration
> [ 38.848667] LDO16: regulator suspend disable supported
> [ 38.853889] LDO15: regulator suspend disable supported
> [ 38.858931] LDO14: regulator suspend disable supported
> [ 38.863771] VDDQ_C2C_W_1.8V: No configuration
> [ 38.868378] LDO12: regulator suspend disable supported
> [ 38.873508] LDO11: regulator suspend disable supported
> [ 38.878545] LDO10: regulator suspend disable supported
> [ 38.883384] LDO9: No configuration
> [ 38.887190] LDO8: regulator suspend disable supported
> [ 38.892168] LDO7: regulator suspend disable supported
> [ 38.897279] LDO6: regulator suspend disable supported
> [ 38.901872] VDDQ_MMC1_3_1.8V: No configuration
> [ 38.906363] VDDQ_MMC2_2.8V: No configuration
> [ 38.910541] VDDQ_EXT_1.8V: No configuration
> [ 38.915134] LDO2: regulator suspend disable supported
> [ 38.919753] VDD_ALIVE_1.0V: No configuration
> [ 38.935229] usb3503 0-0008: switched to STANDBY mode
> [ 38.935981] wake enabled for irq 123
> [ 38.955192] samsung-pinctrl 1100.pinctrl: Setting external
> wakeup interrupt mask: 0xfbfff7ff
> [ 38.975448] Disabling non-boot CPUs ...
> [ 39.029279] s3c2410-wdt 1006.watchdog: watchdog disabled
> [ 39.029576] wake disabled for irq 123
> [ 39.044319] usb3503 0-0008: switched to HUB mode
> [ 39.144089] wake disabled for irq 119
> [ 39.144812] dwc2 1248.hsotg: resuming usb gadget g_ether
> [ 39.422626] usb 1-2: reset high-speed USB device number 2 using exynos-ehci
> [ 39.774632] usb 1-3: reset high-speed USB device number 3 using exynos-ehci
> [ 40.106478] OOM killer enabled.
> [ 40.106609] Restarting tasks ... done.
> [ 40.00] PM: suspend exit
> [ 40.124058] mmc_host mmc1: Bus speed
Re: [PATCH v1] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
Hi Krzysztof,
Thanks your for your valuable comments.
I will try to answer your queries to best of my knowledge.
On Mon, 25 Mar 2019 at 18:16, Krzysztof Kozlowski wrote:
>
> On Sun, 24 Mar 2019 at 09:33, Anand Moon wrote:
> >
> > Add suspend-to-mem node to regulator core to be enabled or disabled
> > during system suspend and also support changing the regulator operating
> > mode during runtime and when the system enter sleep mode (stand by mode).
> >
> > Cc: Marek Szyprowski
> > Cc: Krzysztof Kozlowski
> > Cc: Chanwoo Choi
> > Signed-off-by: Anand Moon
> > ---
> > Current patch:
> >
> > Note: Both microSD and eMMC suspend resume works this changes at my end.
> >
> > regulator-off-in-suspend:
> > set the regulator node into suspend state i.e. standby mode during suspend
> > operation.
> >
> > Current changes are based on
> > [0]
> > https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
> >
> > Regulators which can be turned off during system suspend:
> > -LDOn : 2, 6-8, 10-12, 14-16,
> > -BUCKn : 1-4.
> > Use standard regulator bindings for it ('regulator-off-in-suspend').
> >
> > drop the suspend off binding which are not supported by the driver.
> >
> > RFC version
> > [1] https://patchwork.kernel.org/patch/10810909/
> > These changes had some problem with eMMC not entering into suspend mode.
> > with some miss configuration in regulator-off-in-suspend mode.
> >
> > Changes from previos patch.
> > [2] https://patchwork.kernel.org/patch/10712549/
> >
> > Set all the non used regulator in suspend-odd state
> > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
> >
> > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> > ---
> > .../boot/dts/exynos4412-odroid-common.dtsi| 39 +++
> > 1 file changed, 39 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > index 08d3a0a7b4eb..375156ad5454 100644
> > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > @@ -288,6 +288,9 @@
> > regulator-min-microvolt = <180>;
> > regulator-max-microvolt = <180>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
>
> Please maintain proper versioning of patches.
> First patch sent to lists should be either RFC or v1. Second
> release/submission is then always v2. Third v3.
I tried to mixed up some changes that's the reason.
Ok if needed next version will be Patch V3.
>
> This is third or fourth submission but you marked it as v1. This makes
> it very difficult to discuss and reference previous versions.
>
> The commit message did not change since beginning (first version). I
> asked twice that you need to explain exactly why you put the the
> regulator to off or on state in suspend. Why?
> Because:
> 1. This change looks without justification - once you put on, then you
> put off, now again on,
> 2. Anyone reading the code later must know the rationale why this was done,
> 3. I am not quite sure whether this is good setting so I would be
> happy to be convinced.
>
Like I mention in the patch summary that this.
Current changes are based on
[0]
https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
Regulators which can be turned off during system suspend:
-LDOn : 2, 6-8, 10-12, 14-16,
-BUCKn : 1-4.
Use standard regulator bindings for it ('regulator-off-in-suspend').
> How to provide such explanation? The best in commit message. Sometimes
> in the comment in the code, depends.
Ok I have been testing with following regulator debug prints to catch error.
[0] max77686-regulator.patch
below is the console logs during suspend and resume.
---
Last login: Sat Mar 23 18:22:46 on ttySAC1
[root@archl-u3e ~]# echo no > /sys/module/printk/parameters/console_suspend
[root@archl-u3e ~]# rtcwake -d /dev/rtc0 -m mem -s 10
rtcwake: wakeup from "mem" using /dev/rtc0 at Sat Mar 23 19:56:17 2019
[ 38.595854] PM: suspend entry (deep)
[ 38.596603] PM: Syncing filesystems ... done.
[ 38.629351] Freezing user space processes ... (elapsed 0.002 seconds) done.
[ 38.633192] OOM killer disabled.
[ 38.636035] Freezing remaining freezable tasks ... (elapsed 0.001
seconds) done.
[ 38.675059] smsc95xx 1-2:1.0 eth0: entering SUSPEND2 mode
[ 38.753120] dwc2 1248.hsotg: suspending usb gadget g_ether
[ 38.754007] dwc2 1248.hsotg: new device is full-speed
[ 38.758960] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
[ 38.765507] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
[ 38.774050] wake enabled for irq 119
[ 38.775761]
Re: [PATCH v1] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
On Mon, 25 Mar 2019 at 13:46, Krzysztof Kozlowski wrote:
>
> On Sun, 24 Mar 2019 at 09:33, Anand Moon wrote:
> >
> > Add suspend-to-mem node to regulator core to be enabled or disabled
> > during system suspend and also support changing the regulator operating
> > mode during runtime and when the system enter sleep mode (stand by mode).
> >
> > Cc: Marek Szyprowski
> > Cc: Krzysztof Kozlowski
> > Cc: Chanwoo Choi
> > Signed-off-by: Anand Moon
> > ---
> > Current patch:
> >
> > Note: Both microSD and eMMC suspend resume works this changes at my end.
> >
> > regulator-off-in-suspend:
> > set the regulator node into suspend state i.e. standby mode during suspend
> > operation.
> >
> > Current changes are based on
> > [0]
> > https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
> >
> > Regulators which can be turned off during system suspend:
> > -LDOn : 2, 6-8, 10-12, 14-16,
> > -BUCKn : 1-4.
> > Use standard regulator bindings for it ('regulator-off-in-suspend').
> >
> > drop the suspend off binding which are not supported by the driver.
> >
> > RFC version
> > [1] https://patchwork.kernel.org/patch/10810909/
> > These changes had some problem with eMMC not entering into suspend mode.
> > with some miss configuration in regulator-off-in-suspend mode.
> >
> > Changes from previos patch.
> > [2] https://patchwork.kernel.org/patch/10712549/
> >
> > Set all the non used regulator in suspend-odd state
> > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
> >
> > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> > ---
> > .../boot/dts/exynos4412-odroid-common.dtsi| 39 +++
> > 1 file changed, 39 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > index 08d3a0a7b4eb..375156ad5454 100644
> > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > @@ -288,6 +288,9 @@
> > regulator-min-microvolt = <180>;
> > regulator-max-microvolt = <180>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
>
> Please maintain proper versioning of patches.
> First patch sent to lists should be either RFC or v1. Second
> release/submission is then always v2. Third v3.
>
> This is third or fourth submission but you marked it as v1. This makes
> it very difficult to discuss and reference previous versions.
>
> The commit message did not change since beginning (first version). I
> asked twice that you need to explain exactly why you put the the
> regulator to off or on state in suspend. Why?
> Because:
> 1. This change looks without justification - once you put on, then you
> put off, now again on,
> 2. Anyone reading the code later must know the rationale why this was done,
> 3. I am not quite sure whether this is good setting so I would be
> happy to be convinced.
>
> How to provide such explanation? The best in commit message. Sometimes
> in the comment in the code, depends.
> How such explanation could look like? For example like this:
> f8f3b7fc21b1 ("ARM: dts: exynos: Fix regulators configuration on Peach
> Pi/Pit Chromebooks")
> Marek clearly explained why he put the regulators "always-on", even
> tough we do not know everything about this. More over, he mentions
> that this fixes specific issue.
>
> Summarizing, please answer:
> 1. Why this is made off-in-suspend?
> 2. Why this can be made off-in-suspend?
>
> > + };
> > };
> >
> > ldo3_reg: LDO3 {
> > @@ -317,6 +320,9 @@
> > regulator-min-microvolt = <100>;
> > regulator-max-microvolt = <100>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
> > };
> >
> > ldo7_reg: LDO7 {
> > @@ -324,18 +330,27 @@
> > regulator-min-microvolt = <100>;
> > regulator-max-microvolt = <100>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
> > };
> >
> > ldo8_reg: LDO8 {
> > regulator-name = "VDD10_HDMI_1.0V";
> > regulator-min-microvolt = <100>;
> > regulator-max-microvolt =
Re: [PATCH v1] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
On Sun, 24 Mar 2019 at 09:33, Anand Moon wrote:
>
> Add suspend-to-mem node to regulator core to be enabled or disabled
> during system suspend and also support changing the regulator operating
> mode during runtime and when the system enter sleep mode (stand by mode).
>
> Cc: Marek Szyprowski
> Cc: Krzysztof Kozlowski
> Cc: Chanwoo Choi
> Signed-off-by: Anand Moon
> ---
> Current patch:
>
> Note: Both microSD and eMMC suspend resume works this changes at my end.
>
> regulator-off-in-suspend:
> set the regulator node into suspend state i.e. standby mode during suspend
> operation.
>
> Current changes are based on
> [0]
> https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
>
> Regulators which can be turned off during system suspend:
> -LDOn : 2, 6-8, 10-12, 14-16,
> -BUCKn : 1-4.
> Use standard regulator bindings for it ('regulator-off-in-suspend').
>
> drop the suspend off binding which are not supported by the driver.
>
> RFC version
> [1] https://patchwork.kernel.org/patch/10810909/
> These changes had some problem with eMMC not entering into suspend mode.
> with some miss configuration in regulator-off-in-suspend mode.
>
> Changes from previos patch.
> [2] https://patchwork.kernel.org/patch/10712549/
>
> Set all the non used regulator in suspend-odd state
> LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
>
> BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> ---
> .../boot/dts/exynos4412-odroid-common.dtsi| 39 +++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 08d3a0a7b4eb..375156ad5454 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -288,6 +288,9 @@
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
Please maintain proper versioning of patches.
First patch sent to lists should be either RFC or v1. Second
release/submission is then always v2. Third v3.
This is third or fourth submission but you marked it as v1. This makes
it very difficult to discuss and reference previous versions.
The commit message did not change since beginning (first version). I
asked twice that you need to explain exactly why you put the the
regulator to off or on state in suspend. Why?
Because:
1. This change looks without justification - once you put on, then you
put off, now again on,
2. Anyone reading the code later must know the rationale why this was done,
3. I am not quite sure whether this is good setting so I would be
happy to be convinced.
How to provide such explanation? The best in commit message. Sometimes
in the comment in the code, depends.
How such explanation could look like? For example like this:
f8f3b7fc21b1 ("ARM: dts: exynos: Fix regulators configuration on Peach
Pi/Pit Chromebooks")
Marek clearly explained why he put the regulators "always-on", even
tough we do not know everything about this. More over, he mentions
that this fixes specific issue.
Summarizing, please answer:
1. Why this is made off-in-suspend?
2. Why this can be made off-in-suspend?
> + };
> };
>
> ldo3_reg: LDO3 {
> @@ -317,6 +320,9 @@
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> ldo7_reg: LDO7 {
> @@ -324,18 +330,27 @@
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> ldo8_reg: LDO8 {
> regulator-name = "VDD10_HDMI_1.0V";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> ldo10_reg: LDO10 {
>
[PATCH v1] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
Add suspend-to-mem node to regulator core to be enabled or disabled
during system suspend and also support changing the regulator operating
mode during runtime and when the system enter sleep mode (stand by mode).
Cc: Marek Szyprowski
Cc: Krzysztof Kozlowski
Cc: Chanwoo Choi
Signed-off-by: Anand Moon
---
Current patch:
Note: Both microSD and eMMC suspend resume works this changes at my end.
regulator-off-in-suspend:
set the regulator node into suspend state i.e. standby mode during suspend
operation.
Current changes are based on
[0]
https://www.kernel.org/doc/Documentation/devicetree/bindings/regulator/max77686.txt
Regulators which can be turned off during system suspend:
-LDOn : 2, 6-8, 10-12, 14-16,
-BUCKn : 1-4.
Use standard regulator bindings for it ('regulator-off-in-suspend').
drop the suspend off binding which are not supported by the driver.
RFC version
[1] https://patchwork.kernel.org/patch/10810909/
These changes had some problem with eMMC not entering into suspend mode.
with some miss configuration in regulator-off-in-suspend mode.
Changes from previos patch.
[2] https://patchwork.kernel.org/patch/10712549/
Set all the non used regulator in suspend-odd state
LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
---
.../boot/dts/exynos4412-odroid-common.dtsi| 39 +++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 08d3a0a7b4eb..375156ad5454 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -288,6 +288,9 @@
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo3_reg: LDO3 {
@@ -317,6 +320,9 @@
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo7_reg: LDO7 {
@@ -324,18 +330,27 @@
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo8_reg: LDO8 {
regulator-name = "VDD10_HDMI_1.0V";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo10_reg: LDO10 {
regulator-name = "VDDQ_MIPIHSI_1.8V";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo11_reg: LDO11 {
@@ -343,6 +358,9 @@
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo12_reg: LDO12 {
@@ -351,6 +369,9 @@
regulator-max-microvolt = <330>;
regulator-always-on;
regulator-boot-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo13_reg: LDO13 {
@@ -367,6 +388,9 @@
regulator-max-microvolt = <180>;
regulator-always-on;
regulator-boot-on;
+
