Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
On 07/02/2014 06:19 PM, Russell King - ARM Linux wrote: On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote: Hi Guys, What about this patch? The only concern on the face of it is that it removes mutual exclusion from the pci config write path, where a read-modifiy-write operation is

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Russell King - ARM Linux
On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote: > Hi Guys, > > What about this patch? The only concern on the face of it is that it removes mutual exclusion from the pci config write path, where a read-modifiy-write operation is performed. However, the PCI code already gives that

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
Hi Guys, What about this patch? Thanks Wei On 07/01/2014 03:41 PM, wei.y...@windriver.com wrote: From: Yang Wei The pair read/write of accessing pci confiuration space function has already protected by pci_lock. so remove nano_lock. Signed-off-by: Yang Wei ---

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
Hi Guys, What about this patch? Thanks Wei On 07/01/2014 03:41 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com The pair read/write of accessing pci confiuration space function has already protected by pci_lock. so remove nano_lock. Signed-off-by: Yang Wei

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Russell King - ARM Linux
On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote: Hi Guys, What about this patch? The only concern on the face of it is that it removes mutual exclusion from the pci config write path, where a read-modifiy-write operation is performed. However, the PCI code already gives that

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
On 07/02/2014 06:19 PM, Russell King - ARM Linux wrote: On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote: Hi Guys, What about this patch? The only concern on the face of it is that it removes mutual exclusion from the pci config write path, where a read-modifiy-write operation is

[PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-01 Thread Wei.Yang
From: Yang Wei The pair read/write of accessing pci confiuration space function has already protected by pci_lock. so remove nano_lock. Signed-off-by: Yang Wei --- arch/arm/mach-sa1100/pci-nanoengine.c |9 - 1 file changed, 9 deletions(-) diff --git

[PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-01 Thread Wei.Yang
From: Yang Wei wei.y...@windriver.com The pair read/write of accessing pci confiuration space function has already protected by pci_lock. so remove nano_lock. Signed-off-by: Yang Wei wei.y...@windriver.com --- arch/arm/mach-sa1100/pci-nanoengine.c |9 - 1 file changed, 9