Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-07-17 Thread Dejin Zheng
On Wed, Jul 15, 2020 at 05:45:59PM +0100, Lorenzo Pieralisi wrote: > On Sat, Jul 11, 2020 at 03:47:33PM +0800, Dejin Zheng wrote: > > On Mon, Jul 06, 2020 at 04:58:47PM +0100, Lorenzo Pieralisi wrote: > > > On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote: > > > > > > [...] > > > > >

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-07-15 Thread Lorenzo Pieralisi
On Sat, Jul 11, 2020 at 03:47:33PM +0800, Dejin Zheng wrote: > On Mon, Jul 06, 2020 at 04:58:47PM +0100, Lorenzo Pieralisi wrote: > > On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote: > > > > [...] > > > > > > The other 2 error cases as well don't print the resource name as far as > >

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-07-11 Thread Dejin Zheng
On Mon, Jul 06, 2020 at 04:58:47PM +0100, Lorenzo Pieralisi wrote: > On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote: > > [...] > > > > The other 2 error cases as well don't print the resource name as far as > > > I recall (they will at least print the resource start/end). > > > >

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-07-06 Thread Lorenzo Pieralisi
On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote: [...] > > > In fact, I think its error handling is clear enough, It just goes > > > wrong > > > in three places, as follows: > > > > > > void __iomem *devm_pci_remap_cfg_resource(struct device *dev, > > >

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-06-02 Thread Rob Herring
On Tue, Jun 2, 2020 at 1:44 AM Chocron, Jonathan wrote: > > On Wed, 2020-05-27 at 21:20 +0800, Dejin Zheng wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > >

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-06-02 Thread Chocron, Jonathan
On Wed, 2020-05-27 at 21:20 +0800, Dejin Zheng wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On Tue, May 26, 2020 at 06:22:56PM +, Chocron, Jonathan

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-06-01 Thread Rob Herring
On Tue, 26 May 2020 23:09:54 +0800, Dejin Zheng wrote: > It will print an error message by itself when > devm_pci_remap_cfg_resource() goes wrong. so remove the duplicate > error message. > > Signed-off-by: Dejin Zheng > --- > drivers/pci/controller/cadence/pcie-cadence-host.c | 4 +--- >

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-05-27 Thread Dejin Zheng
On Tue, May 26, 2020 at 06:22:56PM +, Chocron, Jonathan wrote: > On Tue, 2020-05-26 at 23:09 +0800, Dejin Zheng wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-05-26 Thread Chocron, Jonathan
On Tue, 2020-05-26 at 23:09 +0800, Dejin Zheng wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > It will print an error message by itself when >

[PATCH v1] PCI: controller: Remove duplicate error message

2020-05-26 Thread Dejin Zheng
It will print an error message by itself when devm_pci_remap_cfg_resource() goes wrong. so remove the duplicate error message. Signed-off-by: Dejin Zheng --- drivers/pci/controller/cadence/pcie-cadence-host.c | 4 +--- drivers/pci/controller/dwc/pcie-al.c | 13 +++--