Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 10:44:59AM +0100, Lee Jones wrote: > On Thu, 04 Apr 2019, Andy Shevchenko wrote: > > On Thu, Apr 04, 2019 at 10:03:14AM +0100, Lee Jones wrote: > > > On Thu, 04 Apr 2019, Andy Shevchenko wrote: > > > > On Thu, Apr 04, 2019 at 08:03:57AM +0100, Lee Jones wrote: > > > > > On

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Lee Jones
On Thu, 04 Apr 2019, Andy Shevchenko wrote: > On Thu, Apr 04, 2019 at 10:03:14AM +0100, Lee Jones wrote: > > On Thu, 04 Apr 2019, Andy Shevchenko wrote: > > > On Thu, Apr 04, 2019 at 08:03:57AM +0100, Lee Jones wrote: > > > > On Thu, 04 Apr 2019, Lee Jones wrote: > > > > > On Tue, 02 Apr 2019,

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 10:03:14AM +0100, Lee Jones wrote: > On Thu, 04 Apr 2019, Andy Shevchenko wrote: > > On Thu, Apr 04, 2019 at 08:03:57AM +0100, Lee Jones wrote: > > > On Thu, 04 Apr 2019, Lee Jones wrote: > > > > On Tue, 02 Apr 2019, Andy Shevchenko wrote: > > > > > On Tue, Apr 02, 2019 at

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Lee Jones
On Thu, 04 Apr 2019, Andy Shevchenko wrote: > On Thu, Apr 04, 2019 at 08:03:57AM +0100, Lee Jones wrote: > > On Thu, 04 Apr 2019, Lee Jones wrote: > > > On Tue, 02 Apr 2019, Andy Shevchenko wrote: > > > > On Tue, Apr 02, 2019 at 06:12:11AM +0100, Lee Jones wrote: > > > > > On Mon, 18 Mar 2019,

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 08:03:57AM +0100, Lee Jones wrote: > On Thu, 04 Apr 2019, Lee Jones wrote: > > On Tue, 02 Apr 2019, Andy Shevchenko wrote: > > > On Tue, Apr 02, 2019 at 06:12:11AM +0100, Lee Jones wrote: > > > > On Mon, 18 Mar 2019, Andy Shevchenko wrote: > > > > > +static const struct

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Lee Jones
On Thu, 04 Apr 2019, Lee Jones wrote: > On Tue, 02 Apr 2019, Andy Shevchenko wrote: > > > On Tue, Apr 02, 2019 at 06:12:11AM +0100, Lee Jones wrote: > > > On Mon, 18 Mar 2019, Andy Shevchenko wrote: > > > > > > > Add an mfd driver for Intel Merrifield Basin Cove PMIC. > > > > > > Nit:

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Lee Jones
On Tue, 02 Apr 2019, Andy Shevchenko wrote: > On Tue, Apr 02, 2019 at 06:12:11AM +0100, Lee Jones wrote: > > On Mon, 18 Mar 2019, Andy Shevchenko wrote: > > > > > Add an mfd driver for Intel Merrifield Basin Cove PMIC. > > > > Nit: s/mfd/MFD/ > > Noted. And changed for v2. > > > > +static

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-02 Thread Andy Shevchenko
On Tue, Apr 02, 2019 at 03:20:01PM +0300, Andy Shevchenko wrote: > On Tue, Apr 02, 2019 at 06:12:11AM +0100, Lee Jones wrote: > Noted. And changed for v2. > Good point. And changed for v2. s/v2/v3/g -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-02 Thread Andy Shevchenko
On Tue, Apr 02, 2019 at 06:12:11AM +0100, Lee Jones wrote: > On Mon, 18 Mar 2019, Andy Shevchenko wrote: > > > Add an mfd driver for Intel Merrifield Basin Cove PMIC. > > Nit: s/mfd/MFD/ Noted. And changed for v2. > > +static const struct mfd_cell bcove_dev[] = { > > + { > > +

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-01 Thread Lee Jones
On Mon, 18 Mar 2019, Andy Shevchenko wrote: > Add an mfd driver for Intel Merrifield Basin Cove PMIC. Nit: s/mfd/MFD/ > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/Kconfig | 11 ++ > drivers/mfd/Makefile | 1 + >

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-03-18 Thread Andy Shevchenko
On Mon, Mar 18, 2019 at 12:53:16PM +0300, Andy Shevchenko wrote: > Add an mfd driver for Intel Merrifield Basin Cove PMIC. While I waiting for comments here, please, don't apply it either yet. The individual driver names might be changed. So, I will update them in v2 when all parties will be

[PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-03-18 Thread Andy Shevchenko
Add an mfd driver for Intel Merrifield Basin Cove PMIC. Signed-off-by: Andy Shevchenko --- drivers/mfd/Kconfig | 11 ++ drivers/mfd/Makefile | 1 + drivers/mfd/intel_soc_pmic_mrfld.c | 157 +++