Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-03-18 Thread Matthew Wilcox
On Thu, Mar 11, 2021 at 02:00:40PM -0800, Hugh Dickins wrote: > On Thu, 11 Mar 2021, Jue Wang wrote: > > In our experiment with SHMEM THPs, later accesses resulted in a zero > > page allocated instead of a SIGBUS with BUS_MCEERR_AR reported by the > > page fault handler. That part might be an

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-03-11 Thread Hugh Dickins
On Thu, 11 Mar 2021, Jue Wang wrote: > On Thu, Mar 11, 2021 at 7:14 AM HORIGUCHI NAOYA(堀口 直也) > wrote: > > On Wed, Mar 10, 2021 at 11:22:18PM -0800, Hugh Dickins wrote: > > > > > > I'm not much into memory-failure myself, but Jue discovered that the > > > SIGBUS never arrives: because

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-03-11 Thread Jue Wang
Huge thanks to Hugh for his expertise in shmem thps and forwarding this message! Hi Naoya, This is the first time I reply to an email in a Linux upstream thread, apologies for any technical issues due to my email client. And my apologies for the state of the whole patch not quite shareable with

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-03-11 Thread Matthew Wilcox
On Wed, Mar 10, 2021 at 11:22:18PM -0800, Hugh Dickins wrote: > But something we found on the way, > we do have a patch for: add_to_kill() uses page_address_in_vma(), but > that has not been used on file THP tails before - fix appended at the > end below, so as not to waste your time on that bit.

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-03-10 Thread Hugh Dickins
On Tue, 9 Feb 2021, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > Currently hwpoison code checks PageAnon() for thp and refuses to handle > errors on non-anonymous thps (just for historical reason). We now > support non-anonymou thp like shmem one, so this patch suggests to enable > to

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-02-11 Thread Oscar Salvador
On Tue, Feb 09, 2021 at 03:21:28PM +0900, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > Currently hwpoison code checks PageAnon() for thp and refuses to handle > errors on non-anonymous thps (just for historical reason). We now > support non-anonymou thp like shmem one, so this patch

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-02-09 Thread Naoya Horiguchi
On Tue, Feb 09, 2021 at 11:46:40AM -0800, Andrew Morton wrote: > On Tue, 9 Feb 2021 15:21:28 +0900 Naoya Horiguchi > wrote: > > > Currently hwpoison code checks PageAnon() for thp and refuses to handle > > errors on non-anonymous thps (just for historical reason). We now > > support

Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-02-09 Thread Andrew Morton
On Tue, 9 Feb 2021 15:21:28 +0900 Naoya Horiguchi wrote: > Currently hwpoison code checks PageAnon() for thp and refuses to handle > errors on non-anonymous thps (just for historical reason). We now > support non-anonymou thp like shmem one, so this patch suggests to enable > to handle shmem

[PATCH v1] mm, hwpoison: enable error handling on shmem thp

2021-02-08 Thread Naoya Horiguchi
From: Naoya Horiguchi Currently hwpoison code checks PageAnon() for thp and refuses to handle errors on non-anonymous thps (just for historical reason). We now support non-anonymou thp like shmem one, so this patch suggests to enable to handle shmem thps. Fortunately, we already have