Re: [PATCH v1] pwm: add sysfs interface

2013-04-09 Thread Lars Poeschel
On Monday 08 April 2013 at 13:34:58, Thierry Reding wrote: > By the way, would you mind elaborating a bit on the various use-cases > that you have? I'm interested in what people use the PWM subsystem for > and you seem to be the only one currently using it from userspace. I'm > hoping I can get a

Re: [PATCH v1] pwm: add sysfs interface

2013-04-09 Thread Lars Poeschel
On Monday 08 April 2013 at 13:34:58, Thierry Reding wrote: By the way, would you mind elaborating a bit on the various use-cases that you have? I'm interested in what people use the PWM subsystem for and you seem to be the only one currently using it from userspace. I'm hoping I can get a

Re: [PATCH v1] pwm: add sysfs interface

2013-04-08 Thread Lars Poeschel
I have to resend the mail, so the kernel list rejected it. I had HTML enabled in the MUA by mistake. Sorry for the inconvenience! Thierry, thank you for this very complete review! On Monday 08 April 2013 at 10:17:45, Thierry Reding wrote: > On Wed, Apr 03, 2013 at 03:58:55PM +0200, Lars

Re: [PATCH v1] pwm: add sysfs interface

2013-04-08 Thread Thierry Reding
On Mon, Apr 08, 2013 at 01:15:37PM +0200, Lars Poeschel wrote: [...] > You mean change only while a PWM is disabled ?Ok, as said above, I need to be > able to change at least the duty cycle while the PWM is running without > having gaps. But prohibiting changes of the period could be done with

Re: [PATCH v1] pwm: add sysfs interface

2013-04-08 Thread Thierry Reding
On Wed, Apr 03, 2013 at 03:58:55PM +0200, Lars Poeschel wrote: > From: Lars Poeschel > > This adds a simple sysfs interface to the pwm subsystem. It is > heavily inspired by the gpio sysfs interface. > > /sys/class/pwm > /export ... asks the kernel to export a PWM to

Re: [PATCH v1] pwm: add sysfs interface

2013-04-08 Thread Thierry Reding
On Wed, Apr 03, 2013 at 03:58:55PM +0200, Lars Poeschel wrote: From: Lars Poeschel poesc...@lemonage.de This adds a simple sysfs interface to the pwm subsystem. It is heavily inspired by the gpio sysfs interface. /sys/class/pwm /export ... asks the kernel to export

Re: [PATCH v1] pwm: add sysfs interface

2013-04-08 Thread Thierry Reding
On Mon, Apr 08, 2013 at 01:15:37PM +0200, Lars Poeschel wrote: [...] You mean change only while a PWM is disabled ?Ok, as said above, I need to be able to change at least the duty cycle while the PWM is running without having gaps. But prohibiting changes of the period could be done with

Re: [PATCH v1] pwm: add sysfs interface

2013-04-08 Thread Lars Poeschel
I have to resend the mail, so the kernel list rejected it. I had HTML enabled in the MUA by mistake. Sorry for the inconvenience! Thierry, thank you for this very complete review! On Monday 08 April 2013 at 10:17:45, Thierry Reding wrote: On Wed, Apr 03, 2013 at 03:58:55PM +0200, Lars Poeschel

[PATCH v1] pwm: add sysfs interface

2013-04-03 Thread Lars Poeschel
From: Lars Poeschel This adds a simple sysfs interface to the pwm subsystem. It is heavily inspired by the gpio sysfs interface. /sys/class/pwm /export ... asks the kernel to export a PWM to userspace /unexport ... to return a PWM to the kernel

[PATCH v1] pwm: add sysfs interface

2013-04-03 Thread Lars Poeschel
From: Lars Poeschel poesc...@lemonage.de This adds a simple sysfs interface to the pwm subsystem. It is heavily inspired by the gpio sysfs interface. /sys/class/pwm /export ... asks the kernel to export a PWM to userspace /unexport ... to return a PWM to