I will take care your comments.
Thanks
-Arvind
On Monday 23 January 2017 12:54 PM, Julia Lawall wrote:
or general cleanup patches
like this one, you can use the following options, that will just send the
patch to the maintainers, and not to everyone who has ever touched the
I will take care your comments.
Thanks
-Arvind
On Monday 23 January 2017 12:54 PM, Julia Lawall wrote:
or general cleanup patches
like this one, you can use the following options, that will just send the
patch to the maintainers, and not to everyone who has ever touched the
Some comments on the patch header:
* No need to put v1 on a patch. If you are asked to revise it, then you
can start with v2.
* sound: pci: ymfpci: ymfpci_main is not the proper subject line for this
file. Do git log --oneline and see what others have done.
* There should not be a - after the
Some comments on the patch header:
* No need to put v1 on a patch. If you are asked to revise it, then you
can start with v2.
* sound: pci: ymfpci: ymfpci_main is not the proper subject line for this
file. Do git log --oneline and see what others have done.
* There should not be a - after the
Here, If ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.
Signed-off-by: Arvind Yadav
---
sound/pci/ymfpci/ymfpci_main.c | 4
1 file changed, 4 insertions(+)
Here, If ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.
Signed-off-by: Arvind Yadav
---
sound/pci/ymfpci/ymfpci_main.c | 4
1 file changed, 4 insertions(+)
diff --git
6 matches
Mail list logo