Re: [PATCH v1] staging: ccree: fix all whitespace errors

[Dhiru Kholia]

On Sun, May 14, 2017 at 08:53:02AM +0300, Gilad Ben-Yossef wrote:
> Hi Dhiru,
> 
> On Sat, May 13, 2017 at 5:52 PM, Dhiru Kholia  wrote:
> > These whitespace issues were found by the checkpatch.pl script. This
> > patch helps in making the staging tree a bit cleaner.
> >
> > Signed-off-by: Dhiru Kholia 
> > ---
> >  drivers/staging/ccree/TODO|   2 +-
> >  drivers/staging/ccree/cc_bitops.h |   6 +-
> >  drivers/staging/ccree/cc_crypto_ctx.h |   8 +--
> >  drivers/staging/ccree/cc_hal.h|   6 +-
> >  drivers/staging/ccree/cc_hw_queue_defs.h  | 116 
> > +++---
> >  drivers/staging/ccree/cc_lli_defs.h   |   6 +-
> >  drivers/staging/ccree/cc_pal_log.h|  12 ++--
> >  drivers/staging/ccree/cc_pal_log_plat.h   |   6 +-
> >  drivers/staging/ccree/cc_pal_types.h  |  42 +--
> >  drivers/staging/ccree/cc_pal_types_plat.h |   8 +--
> >  drivers/staging/ccree/cc_regs.h   |  10 +--
> >  11 files changed, 111 insertions(+), 111 deletions(-)
> 
> I'm sorry, but your patch doesn't apply after the recent patch set that
> removed some of those files.

True.

The good news is that my patch is no longer needed. The current ccree
code in linux-next seems to be free of any whitespace issues.

Thanks,
Dhiru

Re: [PATCH v1] staging: ccree: fix all whitespace errors

[Gilad Ben-Yossef]

Hi Dhiru,

Thank you for patch.

On Sat, May 13, 2017 at 5:52 PM, Dhiru Kholia  wrote:
> These whitespace issues were found by the checkpatch.pl script. This
> patch helps in making the staging tree a bit cleaner.
>
> Signed-off-by: Dhiru Kholia 
> ---
>  drivers/staging/ccree/TODO|   2 +-
>  drivers/staging/ccree/cc_bitops.h |   6 +-
>  drivers/staging/ccree/cc_crypto_ctx.h |   8 +--
>  drivers/staging/ccree/cc_hal.h|   6 +-
>  drivers/staging/ccree/cc_hw_queue_defs.h  | 116 
> +++---
>  drivers/staging/ccree/cc_lli_defs.h   |   6 +-
>  drivers/staging/ccree/cc_pal_log.h|  12 ++--
>  drivers/staging/ccree/cc_pal_log_plat.h   |   6 +-
>  drivers/staging/ccree/cc_pal_types.h  |  42 +--
>  drivers/staging/ccree/cc_pal_types_plat.h |   8 +--
>  drivers/staging/ccree/cc_regs.h   |  10 +--
>  11 files changed, 111 insertions(+), 111 deletions(-)

I'm sorry, but your patch doesn't apply after the recent patch set that
removed some of those files.

It is indeed hard to follow up ...

Gilad



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

[PATCH v1] staging: ccree: fix all whitespace errors

[Dhiru Kholia]

These whitespace issues were found by the checkpatch.pl script. This
patch helps in making the staging tree a bit cleaner.

Signed-off-by: Dhiru Kholia 
---
 drivers/staging/ccree/TODO|   2 +-
 drivers/staging/ccree/cc_bitops.h |   6 +-
 drivers/staging/ccree/cc_crypto_ctx.h |   8 +--
 drivers/staging/ccree/cc_hal.h|   6 +-
 drivers/staging/ccree/cc_hw_queue_defs.h  | 116 +++---
 drivers/staging/ccree/cc_lli_defs.h   |   6 +-
 drivers/staging/ccree/cc_pal_log.h|  12 ++--
 drivers/staging/ccree/cc_pal_log_plat.h   |   6 +-
 drivers/staging/ccree/cc_pal_types.h  |  42 +--
 drivers/staging/ccree/cc_pal_types_plat.h |   8 +--
 drivers/staging/ccree/cc_regs.h   |  10 +--
 11 files changed, 111 insertions(+), 111 deletions(-)

diff --git a/drivers/staging/ccree/TODO b/drivers/staging/ccree/TODO
index c9f5754..cabe633 100644
--- a/drivers/staging/ccree/TODO
+++ b/drivers/staging/ccree/TODO
@@ -20,7 +20,7 @@ a.k.a stuff fixing for this driver to move out of staging
 8.  Handle the many checkpatch errors.
 9.  Implement ahash import/export correctly.
 10. Go through a proper review of DT bindings and sysfs ABI
-11. Sort out FIPS mode: bake tests into testmgr, sort out behaviour on error, 
+11. Sort out FIPS mode: bake tests into testmgr, sort out behaviour on error,
 figure if 3DES weak key check is needed
 
 Kernel infrastructure items
diff --git a/drivers/staging/ccree/cc_bitops.h 
b/drivers/staging/ccree/cc_bitops.h
index 3a39565..ad3aeed 100644
--- a/drivers/staging/ccree/cc_bitops.h
+++ b/drivers/staging/ccree/cc_bitops.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see .
  */
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h 
b/drivers/staging/ccree/cc_crypto_ctx.h
index 9e10b26..f8ebd76 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see .
  */
@@ -163,7 +163,7 @@ enum drv_hash_mode {
DRV_HASH_SHA512 = 3,
DRV_HASH_SHA384 = 4,
DRV_HASH_MD5 = 5,
-   DRV_HASH_CBC_MAC = 6, 
+   DRV_HASH_CBC_MAC = 6,
DRV_HASH_XCBC_MAC = 7,
DRV_HASH_CMAC = 8,
DRV_HASH_MODE_NUM = 9,
diff --git a/drivers/staging/ccree/cc_hal.h b/drivers/staging/ccree/cc_hal.h
index 75a0ce3..dd1c66d 100644
--- a/drivers/staging/ccree/cc_hal.h
+++ b/drivers/staging/ccree/cc_hal.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see .
  */
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h 
b/drivers/staging/ccree/cc_hw_queue_defs.h
index fbaf1b6..8dca344 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WA

[PATCH v1] staging: ccree: fix all whitespace errors

[Dhiru Kholia]

These whitespace issues were found by the checkpatch.pl script.

Signed-off-by: Dhiru Kholia 
---
 drivers/staging/ccree/TODO|   2 +-
 drivers/staging/ccree/cc_bitops.h |   6 +-
 drivers/staging/ccree/cc_crypto_ctx.h |   8 +--
 drivers/staging/ccree/cc_hal.h|   6 +-
 drivers/staging/ccree/cc_hw_queue_defs.h  | 116 +++---
 drivers/staging/ccree/cc_lli_defs.h   |   6 +-
 drivers/staging/ccree/cc_pal_log.h|  12 ++--
 drivers/staging/ccree/cc_pal_log_plat.h   |   6 +-
 drivers/staging/ccree/cc_pal_types.h  |  42 +--
 drivers/staging/ccree/cc_pal_types_plat.h |   8 +--
 drivers/staging/ccree/cc_regs.h   |  10 +--
 11 files changed, 111 insertions(+), 111 deletions(-)

diff --git a/drivers/staging/ccree/TODO b/drivers/staging/ccree/TODO
index c9f5754..cabe633 100644
--- a/drivers/staging/ccree/TODO
+++ b/drivers/staging/ccree/TODO
@@ -20,7 +20,7 @@ a.k.a stuff fixing for this driver to move out of staging
 8.  Handle the many checkpatch errors.
 9.  Implement ahash import/export correctly.
 10. Go through a proper review of DT bindings and sysfs ABI
-11. Sort out FIPS mode: bake tests into testmgr, sort out behaviour on error, 
+11. Sort out FIPS mode: bake tests into testmgr, sort out behaviour on error,
 figure if 3DES weak key check is needed
 
 Kernel infrastructure items
diff --git a/drivers/staging/ccree/cc_bitops.h 
b/drivers/staging/ccree/cc_bitops.h
index 3a39565..ad3aeed 100644
--- a/drivers/staging/ccree/cc_bitops.h
+++ b/drivers/staging/ccree/cc_bitops.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see .
  */
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h 
b/drivers/staging/ccree/cc_crypto_ctx.h
index 9e10b26..f8ebd76 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see .
  */
@@ -163,7 +163,7 @@ enum drv_hash_mode {
DRV_HASH_SHA512 = 3,
DRV_HASH_SHA384 = 4,
DRV_HASH_MD5 = 5,
-   DRV_HASH_CBC_MAC = 6, 
+   DRV_HASH_CBC_MAC = 6,
DRV_HASH_XCBC_MAC = 7,
DRV_HASH_CMAC = 8,
DRV_HASH_MODE_NUM = 9,
diff --git a/drivers/staging/ccree/cc_hal.h b/drivers/staging/ccree/cc_hal.h
index 75a0ce3..dd1c66d 100644
--- a/drivers/staging/ccree/cc_hal.h
+++ b/drivers/staging/ccree/cc_hal.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see .
  */
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h 
b/drivers/staging/ccree/cc_hw_queue_defs.h
index fbaf1b6..8dca344 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTAB