Re: [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API

2021-03-11 Thread Christoph Hellwig
On Wed, Mar 10, 2021 at 08:28:05AM -0700, Alex Williamson wrote: > > Yes, that series puts vfio_device everywhere so APIs like Alex needs > > to build here become trivial. > > > > The fact we both converged on this same requirement is good > > You're ahead of me in catching up with reviews

Re: [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API

2021-03-10 Thread Alex Williamson
On Wed, 10 Mar 2021 08:19:13 -0400 Jason Gunthorpe wrote: > On Wed, Mar 10, 2021 at 07:48:38AM +, Christoph Hellwig wrote: > > On Mon, Mar 08, 2021 at 02:47:40PM -0700, Alex Williamson wrote: > > > Rather than an errno, return a pointer to the opaque vfio_device > > > to allow the bus

Re: [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API

2021-03-10 Thread Jason Gunthorpe
On Wed, Mar 10, 2021 at 07:48:38AM +, Christoph Hellwig wrote: > On Mon, Mar 08, 2021 at 02:47:40PM -0700, Alex Williamson wrote: > > Rather than an errno, return a pointer to the opaque vfio_device > > to allow the bus driver to call into vfio-core without additional > > lookups and

Re: [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API

2021-03-09 Thread Christoph Hellwig
On Mon, Mar 08, 2021 at 02:47:40PM -0700, Alex Williamson wrote: > Rather than an errno, return a pointer to the opaque vfio_device > to allow the bus driver to call into vfio-core without additional > lookups and references. Note that bus drivers are still required > to use vfio_del_group_dev()

[PATCH v1 02/14] vfio: Update vfio_add_group_dev() API

2021-03-08 Thread Alex Williamson
Rather than an errno, return a pointer to the opaque vfio_device to allow the bus driver to call into vfio-core without additional lookups and references. Note that bus drivers are still required to use vfio_del_group_dev() to teardown the vfio_device. Signed-off-by: Alex Williamson ---