Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Wednesday 09 November 2016 02:36 PM, John Garry wrote: I'd suggest requiring #address-cells=<1> and #size-cells=<0> in the master node, and listing the children by reg property. If the address is not easily expressed as a single integer, use a larger #address-cells value. We already have

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Wednesday 09 November 2016 02:36 PM, John Garry wrote: I'd suggest requiring #address-cells=<1> and #size-cells=<0> in the master node, and listing the children by reg property. If the address is not easily expressed as a single integer, use a larger #address-cells value. We already have

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Thursday 10 November 2016 03:10 AM, Arnd Bergmann wrote: On Wednesday, November 9, 2016 9:58:38 AM CET Anurup M wrote: I also see that the compatible strings have the version included in them, and you can probably drop them by requiring them only in the fallback: compatible =

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Thursday 10 November 2016 03:10 AM, Arnd Bergmann wrote: On Wednesday, November 9, 2016 9:58:38 AM CET Anurup M wrote: I also see that the compatible strings have the version included in them, and you can probably drop them by requiring them only in the fallback: compatible =

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Wednesday, November 9, 2016 9:58:38 AM CET Anurup M wrote: > > > I also see that the compatible strings have the version included in > > them, and you can probably drop them by requiring them only in the > > fallback: > > > > compatible = "hisilicon,hip05-cpu-djtag",

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Wednesday, November 9, 2016 9:58:38 AM CET Anurup M wrote: > > > I also see that the compatible strings have the version included in > > them, and you can probably drop them by requiring them only in the > > fallback: > > > > compatible = "hisilicon,hip05-cpu-djtag",

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 08:40 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: Hi Arnd, Thanks for the reference. I think the i2c interface doesn't fully satisfy our requirements as we need more than just a slave bus address when accessing the slave

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 08:40 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: Hi Arnd, Thanks for the reference. I think the i2c interface doesn't fully satisfy our requirements as we need more than just a slave bus address when accessing the slave

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

I'd suggest requiring #address-cells=<1> and #size-cells=<0> in the master node, and listing the children by reg property. If the address is not easily expressed as a single integer, use a larger #address-cells value. We already have something equivalent to reg in "module-id" (see patch

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

I'd suggest requiring #address-cells=<1> and #size-cells=<0> in the master node, and listing the children by reg property. If the address is not easily expressed as a single integer, use a larger #address-cells value. We already have something equivalent to reg in "module-id" (see patch

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 08:38 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 7:16:30 PM CET Anurup M wrote: If these are backwards compatible, just mark them as compatible in DT, e.g. hip06 can use compatible = "hisilicon,hip06-cpu-djtag-v1", "hisilicon,hip05-cpu-djtag-v1";

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 08:38 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 7:16:30 PM CET Anurup M wrote: If these are backwards compatible, just mark them as compatible in DT, e.g. hip06 can use compatible = "hisilicon,hip06-cpu-djtag-v1", "hisilicon,hip05-cpu-djtag-v1";

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 05:15 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote: On 07/11/2016 20:08, Arnd Bergmann wrote: On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: Hi Arnd, The new bus type tries to model the djtag in a similar

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 05:15 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote: On 07/11/2016 20:08, Arnd Bergmann wrote: On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: Hi Arnd, The new bus type tries to model the djtag in a similar

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 08/11/2016 15:10, Arnd Bergmann wrote: On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: Hi Arnd, Thanks for the reference. I think the i2c interface doesn't fully satisfy our requirements as we need more than just a slave bus address when accessing the slave device (which I

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 08/11/2016 15:10, Arnd Bergmann wrote: On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: Hi Arnd, Thanks for the reference. I think the i2c interface doesn't fully satisfy our requirements as we need more than just a slave bus address when accessing the slave device (which I

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: > > Hi Arnd, > > Thanks for the reference. > > I think the i2c interface doesn't fully satisfy our requirements as we > need more than just a slave bus address when accessing the slave device > (which I think is what i2c uses). We

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote: > > Hi Arnd, > > Thanks for the reference. > > I think the i2c interface doesn't fully satisfy our requirements as we > need more than just a slave bus address when accessing the slave device > (which I think is what i2c uses). We

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 7:16:30 PM CET Anurup M wrote: > If these are backwards compatible, just mark them as compatible in DT, > e.g. hip06 can use > > compatible = "hisilicon,hip06-cpu-djtag-v1", > "hisilicon,hip05-cpu-djtag-v1"; > > so you can tell

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 7:16:30 PM CET Anurup M wrote: > If these are backwards compatible, just mark them as compatible in DT, > e.g. hip06 can use > > compatible = "hisilicon,hip06-cpu-djtag-v1", > "hisilicon,hip05-cpu-djtag-v1"; > > so you can tell

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 08/11/2016 11:45, Arnd Bergmann wrote: On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote: On 07/11/2016 20:08, Arnd Bergmann wrote: On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: Hi Arnd, The new bus type tries to model the djtag in a similar way to I2C/USB

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 08/11/2016 11:45, Arnd Bergmann wrote: On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote: On 07/11/2016 20:08, Arnd Bergmann wrote: On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: Hi Arnd, The new bus type tries to model the djtag in a similar way to I2C/USB

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 05:13 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 1:08:31 PM CET Anurup M wrote: On Tuesday 08 November 2016 12:32 PM, Tan Xiaojun wrote: On 2016/11/7 21:26, Arnd Bergmann wrote: On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: From:

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 05:13 PM, Arnd Bergmann wrote: On Tuesday, November 8, 2016 1:08:31 PM CET Anurup M wrote: On Tuesday 08 November 2016 12:32 PM, Tan Xiaojun wrote: On 2016/11/7 21:26, Arnd Bergmann wrote: On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: From:

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote: > On 07/11/2016 20:08, Arnd Bergmann wrote: > > On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: > >> > >> Hi Arnd, > >> > >> The new bus type tries to model the djtag in a similar way to I2C/USB > >> driver arch, where we

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 1:08:31 PM CET Anurup M wrote: > On Tuesday 08 November 2016 12:32 PM, Tan Xiaojun wrote: > > On 2016/11/7 21:26, Arnd Bergmann wrote: > >> On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: > >>> From: Tan Xiaojun > >>> + /*

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 11:23:35 AM CET John Garry wrote: > On 07/11/2016 20:08, Arnd Bergmann wrote: > > On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: > >> > >> Hi Arnd, > >> > >> The new bus type tries to model the djtag in a similar way to I2C/USB > >> driver arch, where we

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday, November 8, 2016 1:08:31 PM CET Anurup M wrote: > On Tuesday 08 November 2016 12:32 PM, Tan Xiaojun wrote: > > On 2016/11/7 21:26, Arnd Bergmann wrote: > >> On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: > >>> From: Tan Xiaojun > >>> + /* ensure the djtag operation

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 07/11/2016 20:08, Arnd Bergmann wrote: On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: Hi Arnd, The new bus type tries to model the djtag in a similar way to I2C/USB driver arch, where we have a host bus adapter and child devices attached to the bus. The child devices are bus

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 07/11/2016 20:08, Arnd Bergmann wrote: On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: Hi Arnd, The new bus type tries to model the djtag in a similar way to I2C/USB driver arch, where we have a host bus adapter and child devices attached to the bus. The child devices are bus

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 12:32 PM, Tan Xiaojun wrote: On 2016/11/7 21:26, Arnd Bergmann wrote: On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: From: Tan Xiaojun The Hisilicon Djtag is an independent component which connects with some

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Tuesday 08 November 2016 12:32 PM, Tan Xiaojun wrote: On 2016/11/7 21:26, Arnd Bergmann wrote: On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: From: Tan Xiaojun The Hisilicon Djtag is an independent component which connects with some other components in the

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 2016/11/7 21:26, Arnd Bergmann wrote: > On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: >> From: Tan Xiaojun >> >> The Hisilicon Djtag is an independent component which connects >> with some other components in the SoC by Debug Bus. This driver

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 2016/11/7 21:26, Arnd Bergmann wrote: > On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: >> From: Tan Xiaojun >> >> The Hisilicon Djtag is an independent component which connects >> with some other components in the SoC by Debug Bus. This driver >> can be

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: > > Hi Arnd, > > The new bus type tries to model the djtag in a similar way to I2C/USB > driver arch, where we have a host bus adapter and child devices attached > to the bus. The child devices are bus driver devices and have bus >

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Monday, November 7, 2016 2:15:10 PM CET John Garry wrote: > > Hi Arnd, > > The new bus type tries to model the djtag in a similar way to I2C/USB > driver arch, where we have a host bus adapter and child devices attached > to the bus. The child devices are bus driver devices and have bus >

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 07/11/2016 13:26, Arnd Bergmann wrote: On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: From: Tan Xiaojun The Hisilicon Djtag is an independent component which connects with some other components in the SoC by Debug Bus. This driver

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On 07/11/2016 13:26, Arnd Bergmann wrote: On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: From: Tan Xiaojun The Hisilicon Djtag is an independent component which connects with some other components in the SoC by Debug Bus. This driver can be configured

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: > From: Tan Xiaojun > > The Hisilicon Djtag is an independent component which connects > with some other components in the SoC by Debug Bus. This driver > can be configured to access the

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

On Wednesday, November 2, 2016 11:42:46 AM CET Anurup M wrote: > From: Tan Xiaojun > > The Hisilicon Djtag is an independent component which connects > with some other components in the SoC by Debug Bus. This driver > can be configured to access the registers of connecting

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

Hi Tan, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

Hi Tan, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

[PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

From: Tan Xiaojun The Hisilicon Djtag is an independent component which connects with some other components in the SoC by Debug Bus. This driver can be configured to access the registers of connecting components (like L3 cache) during real

[PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

From: Tan Xiaojun The Hisilicon Djtag is an independent component which connects with some other components in the SoC by Debug Bus. This driver can be configured to access the registers of connecting components (like L3 cache) during real time debugging.