Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Christophe Leroy
Le 18/12/2018 à 18:04, Jonathan Neuschäfer a écrit : On Tue, Dec 18, 2018 at 04:04:42PM +0100, Christophe Leroy wrote: Stupid of me. In fact at the time being, BATS cover both RO and RW data areas, so it can definitly not be mapped with PAGE_KERNEL_ROX. In fact, as I have CONFIG_BDI_SWITCH in

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Jonathan Neuschäfer
On Tue, Dec 18, 2018 at 04:04:42PM +0100, Christophe Leroy wrote: > Stupid of me. In fact at the time being, BATS cover both RO and RW data > areas, so it can definitly not be mapped with PAGE_KERNEL_ROX. > > In fact, as I have CONFIG_BDI_SWITCH in my setup, PAGE_KERNEL_TEXT is > PAGE_KERNEL_X on

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Christophe Leroy
Le 18/12/2018 à 15:55, Christophe Leroy a écrit : Le 18/12/2018 à 15:15, Christophe Leroy a écrit : Le 18/12/2018 à 15:07, Jonathan Neuschäfer a écrit : On Tue, Dec 18, 2018 at 09:18:42AM +, Christophe Leroy wrote: The only difference I see then are the flags. Everything else is

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Christophe Leroy
Le 18/12/2018 à 15:15, Christophe Leroy a écrit : Le 18/12/2018 à 15:07, Jonathan Neuschäfer a écrit : On Tue, Dec 18, 2018 at 09:18:42AM +, Christophe Leroy wrote: The only difference I see then are the flags. Everything else is seems identical. I know you tried already, but would

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Christophe Leroy
Le 18/12/2018 à 15:07, Jonathan Neuschäfer a écrit : On Tue, Dec 18, 2018 at 09:18:42AM +, Christophe Leroy wrote: The only difference I see then are the flags. Everything else is seems identical. I know you tried already, but would you mind trying once more with the following change ?

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Jonathan Neuschäfer
On Tue, Dec 18, 2018 at 09:18:42AM +, Christophe Leroy wrote: > The only difference I see then are the flags. Everything else is seems > identical. > > I know you tried already, but would you mind trying once more with the > following change ? > [...] > - setbat(idx, PAGE_OFFSET

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-18 Thread Christophe Leroy
On 12/18/2018 03:05 AM, Jonathan Neuschäfer wrote: On Mon, Dec 17, 2018 at 10:29:18AM +0100, Christophe Leroy wrote: With patches 1-3: [0.00] setbat(0, c000, , 0100, 311) [0.00] setbat(2, c100, 0100, 0080, 311) [0.00] setbat(4, d000,

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-17 Thread Jonathan Neuschäfer
On Mon, Dec 17, 2018 at 10:29:18AM +0100, Christophe Leroy wrote: > > With patches 1-3: > > [0.00] setbat(0, c000, , 0100, 311) > > [0.00] setbat(2, c100, 0100, 0080, 311) > > [0.00] setbat(4, d000, 1000, 0200, 791) > > What we see

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-17 Thread Christophe Leroy
Le 17/12/2018 à 02:28, Jonathan Neuschäfer a écrit : Hi, thanks for your reply. On Thu, Dec 13, 2018 at 03:51:32PM +0100, Christophe Leroy wrote: Hi Again, Le 13/12/2018 à 13:16, Christophe Leroy a écrit : [...] Can you tell/provide the .config and dts used ? I'm using wii.dts and

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-16 Thread Jonathan Neuschäfer
Hi, thanks for your reply. On Thu, Dec 13, 2018 at 03:51:32PM +0100, Christophe Leroy wrote: > Hi Again, > > Le 13/12/2018 à 13:16, Christophe Leroy a écrit : [...] > > Can you tell/provide the .config and dts used ? I'm using wii.dts and almost the wii_defconfig from my tree (save- defconfig

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-13 Thread Christophe Leroy
Hi Again, Le 13/12/2018 à 13:16, Christophe Leroy a écrit : Hi, On 12/03/2018 09:55 PM, Jonathan Neuschäfer wrote: Hi, On Thu, Nov 29, 2018 at 07:00:16PM +, Christophe Leroy wrote: This patch reworks mmu_mapin_ram() to be more generic and map as much blocks as possible. It now supports

Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()

2018-12-13 Thread Christophe Leroy
Hi, On 12/03/2018 09:55 PM, Jonathan Neuschäfer wrote: Hi, On Thu, Nov 29, 2018 at 07:00:16PM +, Christophe Leroy wrote: This patch reworks mmu_mapin_ram() to be more generic and map as much blocks as possible. It now supports blocks not starting at address 0. It scans DBATs array to