Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-25 Thread Dmitry Torokhov
On Wed, Jul 25, 2018 at 03:26:41PM +1000, Peter Hutterer wrote: > On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > > wrote: > > > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > > From: Nick Dyer > >

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-25 Thread Dmitry Torokhov
On Wed, Jul 25, 2018 at 03:26:41PM +1000, Peter Hutterer wrote: > On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > > wrote: > > > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > > From: Nick Dyer > >

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-24 Thread Peter Hutterer
On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > wrote: > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > From: Nick Dyer > > > > > > input_mt_report_slot_state() ignores the tool when the slot is

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-24 Thread Peter Hutterer
On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > wrote: > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > From: Nick Dyer > > > > > > input_mt_report_slot_state() ignores the tool when the slot is

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-24 Thread Benjamin Tissoires
On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov wrote: > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > From: Nick Dyer > > > > input_mt_report_slot_state() ignores the tool when the slot is closed. > > Remove the tool type from these function calls, which has caused a bit of

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-24 Thread Benjamin Tissoires
On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov wrote: > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > From: Nick Dyer > > > > input_mt_report_slot_state() ignores the tool when the slot is closed. > > Remove the tool type from these function calls, which has caused a bit of

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-23 Thread Dmitry Torokhov
On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > From: Nick Dyer > > input_mt_report_slot_state() ignores the tool when the slot is closed. > Remove the tool type from these function calls, which has caused a bit of > confusion. Hmm, maybe we could introduce MT_TOOL_NONE or

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-23 Thread Dmitry Torokhov
On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > From: Nick Dyer > > input_mt_report_slot_state() ignores the tool when the slot is closed. > Remove the tool type from these function calls, which has caused a bit of > confusion. Hmm, maybe we could introduce MT_TOOL_NONE or

[PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-20 Thread Nick Dyer
From: Nick Dyer input_mt_report_slot_state() ignores the tool when the slot is closed. Remove the tool type from these function calls, which has caused a bit of confusion. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-20 Thread Nick Dyer
From: Nick Dyer input_mt_report_slot_state() ignores the tool when the slot is closed. Remove the tool type from these function calls, which has caused a bit of confusion. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 5 ++--- 1 file changed, 2 insertions(+), 3