Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread Guenter Roeck
On Wed, Aug 27, 2014 at 10:56:20AM -0700, David Riley wrote: > Hi Sebastian, > > Thanks for the feedback. > > On Tue, Aug 26, 2014 at 6:43 PM, Sebastian Reichel wrote: > > Hi David, > > > > On Tue, Aug 26, 2014 at 04:45:05PM -0700, David Riley wrote: > >> This driver registers a restart handler

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread David Riley
On Tue, Aug 26, 2014 at 7:40 PM, Guenter Roeck wrote: > On 08/26/2014 04:45 PM, David Riley wrote: >> >> This driver registers a restart handler to set a GPIO line high/low >> to reset a board based on devicetree bindings. >> >> Signed-off-by: David Riley >> --- >>

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread David Riley
Hi Olof, On Tue, Aug 26, 2014 at 7:14 PM, Olof Johansson wrote: > Hi, > > > > On Tue, Aug 26, 2014 at 4:45 PM, David Riley wrote: >> This driver registers a restart handler to set a GPIO line high/low >> to reset a board based on devicetree bindings. >> >> Signed-off-by: David Riley >> --- >>

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread David Riley
Hi Sebastian, Thanks for the feedback. On Tue, Aug 26, 2014 at 6:43 PM, Sebastian Reichel wrote: > Hi David, > > On Tue, Aug 26, 2014 at 04:45:05PM -0700, David Riley wrote: >> This driver registers a restart handler to set a GPIO line high/low >> to reset a board based on devicetree bindings.

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread David Riley
Hi Sebastian, Thanks for the feedback. On Tue, Aug 26, 2014 at 6:43 PM, Sebastian Reichel s...@kernel.org wrote: Hi David, On Tue, Aug 26, 2014 at 04:45:05PM -0700, David Riley wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread David Riley
Hi Olof, On Tue, Aug 26, 2014 at 7:14 PM, Olof Johansson o...@lixom.net wrote: Hi, On Tue, Aug 26, 2014 at 4:45 PM, David Riley davidri...@chromium.org wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by:

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread David Riley
On Tue, Aug 26, 2014 at 7:40 PM, Guenter Roeck li...@roeck-us.net wrote: On 08/26/2014 04:45 PM, David Riley wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by: David Riley davidri...@chromium.org ---

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-27 Thread Guenter Roeck
On Wed, Aug 27, 2014 at 10:56:20AM -0700, David Riley wrote: Hi Sebastian, Thanks for the feedback. On Tue, Aug 26, 2014 at 6:43 PM, Sebastian Reichel s...@kernel.org wrote: Hi David, On Tue, Aug 26, 2014 at 04:45:05PM -0700, David Riley wrote: This driver registers a restart

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread Guenter Roeck
On 08/26/2014 04:45 PM, David Riley wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by: David Riley --- .../devicetree/bindings/gpio/gpio-restart.txt | 48 +++ drivers/power/reset/Kconfig

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread Olof Johansson
Hi, On Tue, Aug 26, 2014 at 4:45 PM, David Riley wrote: > This driver registers a restart handler to set a GPIO line high/low > to reset a board based on devicetree bindings. > > Signed-off-by: David Riley > --- > .../devicetree/bindings/gpio/gpio-restart.txt | 48 +++ >

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread Sebastian Reichel
Hi David, On Tue, Aug 26, 2014 at 04:45:05PM -0700, David Riley wrote: > This driver registers a restart handler to set a GPIO line high/low > to reset a board based on devicetree bindings. Driver looks fine to me. I have some comments about the Documentation, though: > [...] > diff --git

[PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread David Riley
This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by: David Riley --- .../devicetree/bindings/gpio/gpio-restart.txt | 48 +++ drivers/power/reset/Kconfig| 8 ++

[PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread David Riley
This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by: David Riley davidri...@chromium.org --- .../devicetree/bindings/gpio/gpio-restart.txt | 48 +++ drivers/power/reset/Kconfig| 8 ++

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread Sebastian Reichel
Hi David, On Tue, Aug 26, 2014 at 04:45:05PM -0700, David Riley wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Driver looks fine to me. I have some comments about the Documentation, though: [...] diff --git

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread Olof Johansson
Hi, On Tue, Aug 26, 2014 at 4:45 PM, David Riley davidri...@chromium.org wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by: David Riley davidri...@chromium.org ---

Re: [PATCH v1 1/1] power: Add simple gpio-restart driver

2014-08-26 Thread Guenter Roeck
On 08/26/2014 04:45 PM, David Riley wrote: This driver registers a restart handler to set a GPIO line high/low to reset a board based on devicetree bindings. Signed-off-by: David Riley davidri...@chromium.org --- .../devicetree/bindings/gpio/gpio-restart.txt | 48 +++