Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-09 Thread Srinivas Kandagatla
On 07/03/15 15:00, Mark Brown wrote: On Thu, Mar 05, 2015 at 09:45:41AM +, Srinivas Kandagatla wrote: + + return eeprom; +} +EXPORT_SYMBOL(eeprom_register); This framework uses regmap but regmap is EXPORT_SYMBOL_GPL() and this is using EXPORT_SYMBOL(). Thanks for spotting this,

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-09 Thread Srinivas Kandagatla
On 07/03/15 15:00, Mark Brown wrote: On Thu, Mar 05, 2015 at 09:45:41AM +, Srinivas Kandagatla wrote: + + return eeprom; +} +EXPORT_SYMBOL(eeprom_register); This framework uses regmap but regmap is EXPORT_SYMBOL_GPL() and this is using EXPORT_SYMBOL(). Thanks for spotting this,

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-07 Thread Mark Brown
On Thu, Mar 05, 2015 at 09:45:41AM +, Srinivas Kandagatla wrote: > + > + return eeprom; > +} > +EXPORT_SYMBOL(eeprom_register); This framework uses regmap but regmap is EXPORT_SYMBOL_GPL() and this is using EXPORT_SYMBOL(). > +int eeprom_unregister(struct eeprom_device *eeprom) > +{ > +

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-07 Thread Mark Brown
On Thu, Mar 05, 2015 at 09:45:41AM +, Srinivas Kandagatla wrote: + + return eeprom; +} +EXPORT_SYMBOL(eeprom_register); This framework uses regmap but regmap is EXPORT_SYMBOL_GPL() and this is using EXPORT_SYMBOL(). +int eeprom_unregister(struct eeprom_device *eeprom) +{ +

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-05 Thread Srinivas Kandagatla
On 05/03/15 10:23, Paul Bolle wrote: On Thu, 2015-03-05 at 09:45 +, Srinivas Kandagatla wrote: --- /dev/null +++ b/drivers/eeprom/Kconfig @@ -0,0 +1,20 @@ +menuconfig EEPROM + bool "EEPROM Support" EEPROM is a bool symbol. + depends on OF + select REGMAP + help

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-05 Thread Paul Bolle
On Thu, 2015-03-05 at 09:45 +, Srinivas Kandagatla wrote: > --- /dev/null > +++ b/drivers/eeprom/Kconfig > @@ -0,0 +1,20 @@ > +menuconfig EEPROM > + bool "EEPROM Support" EEPROM is a bool symbol. > + depends on OF > + select REGMAP > + help > + Support for EEPROM alike

[PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-05 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, EEPROM drivers were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they were

[PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-05 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, EEPROM drivers were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they were

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-05 Thread Paul Bolle
On Thu, 2015-03-05 at 09:45 +, Srinivas Kandagatla wrote: --- /dev/null +++ b/drivers/eeprom/Kconfig @@ -0,0 +1,20 @@ +menuconfig EEPROM + bool EEPROM Support EEPROM is a bool symbol. + depends on OF + select REGMAP + help + Support for EEPROM alike devices. +

Re: [PATCH v1 1/6] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-05 Thread Srinivas Kandagatla
On 05/03/15 10:23, Paul Bolle wrote: On Thu, 2015-03-05 at 09:45 +, Srinivas Kandagatla wrote: --- /dev/null +++ b/drivers/eeprom/Kconfig @@ -0,0 +1,20 @@ +menuconfig EEPROM + bool EEPROM Support EEPROM is a bool symbol. + depends on OF + select REGMAP + help +