[PATCH v1 2/2] Revert "irq: Enable all irqs unconditionally in irq_resume"
This reverts the fix to IRQF_EARLY_RESUME irqs staying disabled after a suspend failure. It incorrectly stated that Xen is the only platform that uses this feature. Some rtc drivers such as rtc-as3722.c use the feature and can have its irq permanently enabled with the change. The driver does disable/enable the irq for the rtc alarm, so it needs a different fix which is in "genirq: Fix error path for resuming irqs" We should also keep correct enable/disable parity for irqs. This reverts commit ac01810c9d2814238f08a227062e66a35a0e1ea2. Signed-off-by: Derek Basehore --- kernel/irq/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c index b07dc9c..a5eaf1f 100644 --- a/kernel/irq/pm.c +++ b/kernel/irq/pm.c @@ -50,7 +50,7 @@ static void resume_irqs(bool want_early) bool is_early = desc->action && desc->action->flags & IRQF_EARLY_RESUME; - if (!is_early && want_early) + if (is_early != want_early) continue; raw_spin_lock_irqsave(>lock, flags); -- 2.0.0.526.g5318336 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v1 2/2] Revert irq: Enable all irqs unconditionally in irq_resume
This reverts the fix to IRQF_EARLY_RESUME irqs staying disabled after a suspend failure. It incorrectly stated that Xen is the only platform that uses this feature. Some rtc drivers such as rtc-as3722.c use the feature and can have its irq permanently enabled with the change. The driver does disable/enable the irq for the rtc alarm, so it needs a different fix which is in genirq: Fix error path for resuming irqs We should also keep correct enable/disable parity for irqs. This reverts commit ac01810c9d2814238f08a227062e66a35a0e1ea2. Signed-off-by: Derek Basehore dbaseh...@chromium.org --- kernel/irq/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c index b07dc9c..a5eaf1f 100644 --- a/kernel/irq/pm.c +++ b/kernel/irq/pm.c @@ -50,7 +50,7 @@ static void resume_irqs(bool want_early) bool is_early = desc-action desc-action-flags IRQF_EARLY_RESUME; - if (!is_early want_early) + if (is_early != want_early) continue; raw_spin_lock_irqsave(desc-lock, flags); -- 2.0.0.526.g5318336 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
