Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-11 Thread Gwendal Grignou
On Thu, Feb 11, 2016 at 6:52 AM, Tomeu Vizoso wrote: > > On 02/05/2016 06:24 PM, Gwendal Grignou wrote: > > We should not used kmalloc when get events, these functions are called > > quite often. > > Gwendal. > > > > On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso >

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-11 Thread Tomeu Vizoso
On 02/05/2016 06:24 PM, Gwendal Grignou wrote: > We should not used kmalloc when get events, these functions are called > quite often. > Gwendal. > > On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso > wrote: > > +static int

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-11 Thread Lee Jones
On Wed, 10 Feb 2016, Gwendal Grignou wrote: > [Resend[We should not used kmalloc when get events, these functions > are called quite often. > Gwendal. Why are you re-sending [again]? Why are you top posting? Why aren't you cutting the 370 lines before your first comment and the 150 lines after

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-11 Thread Lee Jones
On Wed, 10 Feb 2016, Gwendal Grignou wrote: > [Resend[We should not used kmalloc when get events, these functions > are called quite often. > Gwendal. Why are you re-sending [again]? Why are you top posting? Why aren't you cutting the 370 lines before your first comment and the 150 lines after

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-11 Thread Tomeu Vizoso
On 02/05/2016 06:24 PM, Gwendal Grignou wrote: > We should not used kmalloc when get events, these functions are called > quite often. > Gwendal. > > On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso > wrote: > > +static int

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-11 Thread Gwendal Grignou
On Thu, Feb 11, 2016 at 6:52 AM, Tomeu Vizoso wrote: > > On 02/05/2016 06:24 PM, Gwendal Grignou wrote: > > We should not used kmalloc when get events, these functions are called > > quite often. > > Gwendal. > > > > On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-10 Thread Gwendal Grignou
[Resend[We should not used kmalloc when get events, these functions are called quite often. Gwendal. On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso wrote: > From: Vic Yang > > Newer revisions of the ChromeOS EC add more events besides the keyboard > ones. So handle interrupts in the MFD driver

Re: [PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-10 Thread Gwendal Grignou
[Resend[We should not used kmalloc when get events, these functions are called quite often. Gwendal. On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso wrote: > From: Vic Yang > > Newer revisions of the ChromeOS EC add more events besides the

[PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-05 Thread Tomeu Vizoso
From: Vic Yang Newer revisions of the ChromeOS EC add more events besides the keyboard ones. So handle interrupts in the MFD driver and let consumers register for notifications for the events they might care. To keep backward compatibility, if the EC doesn't support MKBP event, we fall back to

[PATCH v1 2/6] mfd: cros_ec: Add MKBP event support

2016-02-05 Thread Tomeu Vizoso
From: Vic Yang Newer revisions of the ChromeOS EC add more events besides the keyboard ones. So handle interrupts in the MFD driver and let consumers register for notifications for the events they might care. To keep backward compatibility, if the EC doesn't support MKBP