Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-27 Thread Sandeepa Prabhu
On 27 September 2013 21:11, Jiang Liu wrote: > On 09/25/2013 10:35 PM, Sandeepa Prabhu wrote: >> On 25 September 2013 16:14, Jiang Liu wrote: >>> From: Jiang Liu >>> >>> Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() >>> to patch kernel and module code. >>> >>> Function

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-27 Thread Jiang Liu
On 09/25/2013 10:35 PM, Sandeepa Prabhu wrote: > On 25 September 2013 16:14, Jiang Liu wrote: >> From: Jiang Liu >> >> Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() >> to patch kernel and module code. >> >> Function aarch64_insn_patch_text() is a heavy version which may use

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-27 Thread Jiang Liu
On 09/25/2013 10:35 PM, Sandeepa Prabhu wrote: On 25 September 2013 16:14, Jiang Liu liu...@gmail.com wrote: From: Jiang Liu jiang@huawei.com Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() to patch kernel and module code. Function aarch64_insn_patch_text() is a

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-27 Thread Sandeepa Prabhu
On 27 September 2013 21:11, Jiang Liu liu...@gmail.com wrote: On 09/25/2013 10:35 PM, Sandeepa Prabhu wrote: On 25 September 2013 16:14, Jiang Liu liu...@gmail.com wrote: From: Jiang Liu jiang@huawei.com Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() to patch kernel

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 21:24, Jiang Liu wrote: > Hi Sandeepa, > Great to know that you are working on kprobe for ARM64. > I have done some investigation, found it's an huge work for me > then gave up:( > I will try refine the implementation based on your requirement. >

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 20:46, Steven Rostedt wrote: > On Wed, 25 Sep 2013 20:12:17 +0530 > Sandeepa Prabhu wrote: > > >> > On aarch64, are instructions always word aligned? If not, it should be >> > safe for stop machine to modify non word aligned instructions, but this >> > patch looks like it

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Jiang Liu
Hi Sandeepa, Great to know that you are working on kprobe for ARM64. I have done some investigation, found it's an huge work for me then gave up:( I will try refine the implementation based on your requirement. Thanks! On 09/25/2013 10:35 PM, Sandeepa Prabhu wrote: > On 25

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Steven Rostedt
On Wed, 25 Sep 2013 20:12:17 +0530 Sandeepa Prabhu wrote: > > On aarch64, are instructions always word aligned? If not, it should be > > safe for stop machine to modify non word aligned instructions, but this > > patch looks like it doesn't allow stop_machine() to do so. > Steve, > > Yes,

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 20:05, Steven Rostedt wrote: > On Wed, 25 Sep 2013 18:44:22 +0800 > Jiang Liu wrote: >> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c >> index 8541c3a..50facfc 100644 >> --- a/arch/arm64/kernel/insn.c >> +++ b/arch/arm64/kernel/insn.c >> @@ -15,6 +15,8 @@

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Steven Rostedt
On Wed, 25 Sep 2013 18:44:22 +0800 Jiang Liu wrote: > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index 8541c3a..50facfc 100644 > --- a/arch/arm64/kernel/insn.c > +++ b/arch/arm64/kernel/insn.c > @@ -15,6 +15,8 @@ > * along with this program. If not, see

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 16:14, Jiang Liu wrote: > From: Jiang Liu > > Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() > to patch kernel and module code. > > Function aarch64_insn_patch_text() is a heavy version which may use > stop_machine() to serialize all online CPUs, and

[PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Jiang Liu
From: Jiang Liu Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() to patch kernel and module code. Function aarch64_insn_patch_text() is a heavy version which may use stop_machine() to serialize all online CPUs, and function __aarch64_insn_patch_text() is light version without

[PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Jiang Liu
From: Jiang Liu jiang@huawei.com Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() to patch kernel and module code. Function aarch64_insn_patch_text() is a heavy version which may use stop_machine() to serialize all online CPUs, and function __aarch64_insn_patch_text() is

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Steven Rostedt
On Wed, 25 Sep 2013 18:44:22 +0800 Jiang Liu liu...@gmail.com wrote: diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c index 8541c3a..50facfc 100644 --- a/arch/arm64/kernel/insn.c +++ b/arch/arm64/kernel/insn.c @@ -15,6 +15,8 @@ * along with this program. If not, see

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 16:14, Jiang Liu liu...@gmail.com wrote: From: Jiang Liu jiang@huawei.com Introduce aarch64_insn_patch_text() and __aarch64_insn_patch_text() to patch kernel and module code. Function aarch64_insn_patch_text() is a heavy version which may use stop_machine() to

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 20:05, Steven Rostedt rost...@goodmis.org wrote: On Wed, 25 Sep 2013 18:44:22 +0800 Jiang Liu liu...@gmail.com wrote: diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c index 8541c3a..50facfc 100644 --- a/arch/arm64/kernel/insn.c +++

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Steven Rostedt
On Wed, 25 Sep 2013 20:12:17 +0530 Sandeepa Prabhu sandeepa.pra...@linaro.org wrote: On aarch64, are instructions always word aligned? If not, it should be safe for stop machine to modify non word aligned instructions, but this patch looks like it doesn't allow stop_machine() to do so.

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Jiang Liu
Hi Sandeepa, Great to know that you are working on kprobe for ARM64. I have done some investigation, found it's an huge work for me then gave up:( I will try refine the implementation based on your requirement. Thanks! On 09/25/2013 10:35 PM, Sandeepa Prabhu wrote: On 25

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 20:46, Steven Rostedt rost...@goodmis.org wrote: On Wed, 25 Sep 2013 20:12:17 +0530 Sandeepa Prabhu sandeepa.pra...@linaro.org wrote: On aarch64, are instructions always word aligned? If not, it should be safe for stop machine to modify non word aligned instructions,

Re: [PATCH v1 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-09-25 Thread Sandeepa Prabhu
On 25 September 2013 21:24, Jiang Liu liu...@gmail.com wrote: Hi Sandeepa, Great to know that you are working on kprobe for ARM64. I have done some investigation, found it's an huge work for me then gave up:( I will try refine the implementation based on your requirement.