Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-12 Thread Coiby Xu
On Sat, Oct 10, 2020 at 10:40:55PM +0900, Benjamin Poirier wrote: On 2020-10-10 18:00 +0800, Coiby Xu wrote: [...] > > Please also update drivers/staging/qlge/TODO accordingly. There is still > a lot of debugging code IMO (the netif_printk statements - kernel > tracing can be used instead of

Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-10 Thread Benjamin Poirier
On 2020-10-10 18:00 +0800, Coiby Xu wrote: [...] > > > > Please also update drivers/staging/qlge/TODO accordingly. There is still > > a lot of debugging code IMO (the netif_printk statements - kernel > > tracing can be used instead of those) but this patch is a substantial > > improvement. > >

Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-10 Thread Coiby Xu
On Sat, Oct 10, 2020 at 05:01:26PM +0900, Benjamin Poirier wrote: On 2020-10-08 19:58 +0800, Coiby Xu wrote: The debugging code in the following ifdef land - QL_ALL_DUMP - QL_REG_DUMP - QL_DEV_DUMP - QL_CB_DUMP - QL_IB_DUMP - QL_OB_DUMP becomes unnecessary because, - Device status and

Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-10 Thread Benjamin Poirier
On 2020-10-08 19:58 +0800, Coiby Xu wrote: > The debugging code in the following ifdef land > - QL_ALL_DUMP > - QL_REG_DUMP > - QL_DEV_DUMP > - QL_CB_DUMP > - QL_IB_DUMP > - QL_OB_DUMP > > becomes unnecessary because, > - Device status and general registers can be obtained by ethtool. > -

[PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-08 Thread Coiby Xu
The debugging code in the following ifdef land - QL_ALL_DUMP - QL_REG_DUMP - QL_DEV_DUMP - QL_CB_DUMP - QL_IB_DUMP - QL_OB_DUMP becomes unnecessary because, - Device status and general registers can be obtained by ethtool. - Coredump can be done via devlink health reporter. - Structure