Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

* Ricardo Neri wrote: > Plus, one more advantage of using char/short/int/long is that when building a > 32-bit kernel long will be a 32-bit type. Thus, all the aritmetic would be > naturally done with variables of the appropriate width. Perhaps I could

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

* Ricardo Neri wrote: > Plus, one more advantage of using char/short/int/long is that when building a > 32-bit kernel long will be a 32-bit type. Thus, all the aritmetic would be > naturally done with variables of the appropriate width. Perhaps I could use > u8/u16/u32/long? It looks white

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Fri, Nov 03, 2017 at 11:17:49AM +0100, Ingo Molnar wrote: > > * Ricardo Neri wrote: > > > On Thu, Nov 02, 2017 at 09:51:08AM +0100, Ingo Molnar wrote: > > > > > > * Ricardo Neri wrote: > > > > > > > + /* >

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Fri, Nov 03, 2017 at 11:17:49AM +0100, Ingo Molnar wrote: > > * Ricardo Neri wrote: > > > On Thu, Nov 02, 2017 at 09:51:08AM +0100, Ingo Molnar wrote: > > > > > > * Ricardo Neri wrote: > > > > > > > + /* > > > > +* -EDOM means that we must ignore the address_offset. In such

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

* Ricardo Neri wrote: > On Thu, Nov 02, 2017 at 09:51:08AM +0100, Ingo Molnar wrote: > > > > * Ricardo Neri wrote: > > > > > + /* > > > + * -EDOM means that we must ignore the address_offset. In such a case, > > >

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

* Ricardo Neri wrote: > On Thu, Nov 02, 2017 at 09:51:08AM +0100, Ingo Molnar wrote: > > > > * Ricardo Neri wrote: > > > > > + /* > > > + * -EDOM means that we must ignore the address_offset. In such a case, > > > + * in 64-bit mode the effective address relative to the RIP of the > > > +

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Thu, Nov 02, 2017 at 12:07:13PM +0100, Thomas Gleixner wrote: > On Thu, 2 Nov 2017, Ingo Molnar wrote: > > > * Ricardo Neri wrote: > > > > > + /* > > > + * -EDOM means that we must ignore the address_offset. In such a case, > > > + * in 64-bit mode

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Thu, Nov 02, 2017 at 12:07:13PM +0100, Thomas Gleixner wrote: > On Thu, 2 Nov 2017, Ingo Molnar wrote: > > > * Ricardo Neri wrote: > > > > > + /* > > > + * -EDOM means that we must ignore the address_offset. In such a case, > > > + * in 64-bit mode the effective address relative to the

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Thu, Nov 02, 2017 at 09:51:08AM +0100, Ingo Molnar wrote: > > * Ricardo Neri wrote: > > > + /* > > +* -EDOM means that we must ignore the address_offset. In such a case, > > +* in 64-bit mode the effective address relative to the RIP of the >

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Thu, Nov 02, 2017 at 09:51:08AM +0100, Ingo Molnar wrote: > > * Ricardo Neri wrote: > > > + /* > > +* -EDOM means that we must ignore the address_offset. In such a case, > > +* in 64-bit mode the effective address relative to the RIP of the > > +* following instruction. > > +

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Thu, 2 Nov 2017, Ingo Molnar wrote: > * Ricardo Neri wrote: > > > + /* > > +* -EDOM means that we must ignore the address_offset. In such a case, > > +* in 64-bit mode the effective address relative to the RIP of the > > +* following

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

On Thu, 2 Nov 2017, Ingo Molnar wrote: > * Ricardo Neri wrote: > > > + /* > > +* -EDOM means that we must ignore the address_offset. In such a case, > > +* in 64-bit mode the effective address relative to the RIP of the > > +* following instruction. > > +*/ > > + if

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

* Ricardo Neri wrote: > + /* > + * -EDOM means that we must ignore the address_offset. In such a case, > + * in 64-bit mode the effective address relative to the RIP of the > + * following instruction. > + */ > + if (*regoff ==

Re: [PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

* Ricardo Neri wrote: > + /* > + * -EDOM means that we must ignore the address_offset. In such a case, > + * in 64-bit mode the effective address relative to the RIP of the > + * following instruction. > + */ > + if (*regoff == -EDOM) { > + if

[PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

Computing a linear address involves several steps. The first step is to compute the effective address. This involves determining the addressing mode in use and perform arithmetic operations on the operands. Plus, each addressing mode has special cases that must be handled. Once the effective

[PATCH v10 02/13] x86/insn-eval: Compute linear address in several utility functions

Computing a linear address involves several steps. The first step is to compute the effective address. This involves determining the addressing mode in use and perform arithmetic operations on the operands. Plus, each addressing mode has special cases that must be handled. Once the effective