Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-30 Thread Andrey Ryabinin
2015-01-31 0:45 GMT+03:00 Andrew Morton : > On Fri, 30 Jan 2015 20:47:13 +0300 Andrey Ryabinin > wrote: > >> >> +struct kasan_global { >> >> + const void *beg;/* Address of the beginning of the >> >> global variable. */ >> >> + size_t size;/* Size of the

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-30 Thread Andrew Morton
On Fri, 30 Jan 2015 20:47:13 +0300 Andrey Ryabinin wrote: > >> +struct kasan_global { > >> + const void *beg;/* Address of the beginning of the > >> global variable. */ > >> + size_t size;/* Size of the global variable. */ > >> + size_t size_with_redzone;

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-30 Thread Andrey Ryabinin
On 01/30/2015 02:13 AM, Andrew Morton wrote: > On Thu, 29 Jan 2015 18:12:01 +0300 Andrey Ryabinin > wrote: > >> This feature let us to detect accesses out of bounds >> of global variables. > > global variables *within modules*, I think? More specificity needed here. Within modules and within

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-30 Thread Andrey Ryabinin
2015-01-31 0:45 GMT+03:00 Andrew Morton a...@linux-foundation.org: On Fri, 30 Jan 2015 20:47:13 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: +struct kasan_global { + const void *beg;/* Address of the beginning of the global variable. */ + size_t size;

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-30 Thread Andrew Morton
On Fri, 30 Jan 2015 20:47:13 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: +struct kasan_global { + const void *beg;/* Address of the beginning of the global variable. */ + size_t size;/* Size of the global variable. */ + size_t

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-30 Thread Andrey Ryabinin
On 01/30/2015 02:13 AM, Andrew Morton wrote: On Thu, 29 Jan 2015 18:12:01 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: This feature let us to detect accesses out of bounds of global variables. global variables *within modules*, I think? More specificity needed here. Within

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-29 Thread Andrew Morton
On Thu, 29 Jan 2015 18:12:01 +0300 Andrey Ryabinin wrote: > This feature let us to detect accesses out of bounds > of global variables. global variables *within modules*, I think? More specificity needed here. > The idea of this is simple. Compiler increases each global variable > by redzone

[PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-29 Thread Andrey Ryabinin
This feature let us to detect accesses out of bounds of global variables. The idea of this is simple. Compiler increases each global variable by redzone size and add constructors invoking __asan_register_globals() function. Information about global variable (address, size, size with redzone ...)

[PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-29 Thread Andrey Ryabinin
This feature let us to detect accesses out of bounds of global variables. The idea of this is simple. Compiler increases each global variable by redzone size and add constructors invoking __asan_register_globals() function. Information about global variable (address, size, size with redzone ...)

Re: [PATCH v10 17/17] kasan: enable instrumentation of global variables

2015-01-29 Thread Andrew Morton
On Thu, 29 Jan 2015 18:12:01 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: This feature let us to detect accesses out of bounds of global variables. global variables *within modules*, I think? More specificity needed here. The idea of this is simple. Compiler increases each global