Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-20 Thread Wolfram Sang
On Mon, Jun 19, 2017 at 05:58:19PM -0700, Brendan Higgins wrote: > On Mon, Jun 19, 2017 at 7:21 AM, Wolfram Sang wrote: > > > > And any chance for a MAINTAINERS entry? > > > > We already have one: > http://elixir.free-electrons.com/linux/v4.11.5/source/MAINTAINERS#L1090 > > However, if you would

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-19 Thread Brendan Higgins
I thought all of the comments made sense and will be addressed in my next revision, except the following: >> +static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus) >> +{ >> + unsigned long time_left, flags; >> + int ret = 0; >> + u32 command; >> + >> + spin_lock_irqsave(&bu

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-19 Thread Brendan Higgins
On Mon, Jun 19, 2017 at 7:21 AM, Wolfram Sang wrote: > > And any chance for a MAINTAINERS entry? > We already have one: http://elixir.free-electrons.com/linux/v4.11.5/source/MAINTAINERS#L1090 However, if you would like me to own this driver, I could add an entry for myself.

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-19 Thread Wolfram Sang
And any chance for a MAINTAINERS entry? signature.asc Description: PGP signature

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-19 Thread Wolfram Sang
Hi Brendan, here is my review. Only minor stuff, no real show-stopper. > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 144cbadc7c72..280f84a0d7d1 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -326,6 +326,16 @@ config I2C_POWERMAC

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-15 Thread Brendan Higgins
On Sun, Jun 4, 2017 at 10:02 PM, Andrew Jeffery wrote: > On Fri, 2017-06-02 at 18:29 -0700, Brendan Higgins wrote: >> Added initial master support for Aspeed I2C controller. Supports >> fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. >> >> Signed-off-by: Brendan Higgins > > I e

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-04 Thread Andrew Jeffery
On Fri, 2017-06-02 at 18:29 -0700, Brendan Higgins wrote: > Added initial master support for Aspeed I2C controller. Supports > fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. > > Signed-off-by: Brendan Higgins I exercised this patch on an AST2500-based machine. The results wer

Re: [PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-04 Thread Joel Stanley
On Sat, Jun 3, 2017 at 10:59 AM, Brendan Higgins wrote: > Added initial master support for Aspeed I2C controller. Supports > fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. > > Signed-off-by: Brendan Higgins Reviewed-by: Joel Stanley I have also tested this on an ast2500evb.

[PATCH v10 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-02 Thread Brendan Higgins
Added initial master support for Aspeed I2C controller. Supports fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Signed-off-by: Brendan Higgins --- Changes for v2: - Added single module_init (multiple was breaking some builds). Changes for v3: - Removed "bus" device tree pa