Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-11 Thread Sean Christopherson
On Tue, Dec 11, 2018 at 10:10:38AM -0800, Dave Hansen wrote: > On 12/10/18 3:12 PM, Josh Triplett wrote: > >> Or maybe even python/shell scripts? It looked to me like virtual > >> memory will be "interesting" for enclaves. > > Memory management doesn't seem that hard to deal with. > > The

Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-11 Thread Dave Hansen
On 12/10/18 3:12 PM, Josh Triplett wrote: >> Or maybe even python/shell scripts? It looked to me like virtual >> memory will be "interesting" for enclaves. > Memory management doesn't seem that hard to deal with. The problems are: 1. SGX enclave memory (EPC) is statically allocated at boot and

Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-10 Thread Josh Triplett
On Mon, Dec 10, 2018 at 09:27:04AM +0100, Pavel Machek wrote: > On Sun 2018-12-09 23:47:17, Josh Triplett wrote: > > On Sun, Dec 09, 2018 at 09:06:00PM +0100, Pavel Machek wrote: > > ... > > > > > > The default permissions for the device are 600. > > > > > > > > > > Good. This does not belong to

Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-10 Thread Pavel Machek
On Sun 2018-12-09 23:47:17, Josh Triplett wrote: > On Sun, Dec 09, 2018 at 09:06:00PM +0100, Pavel Machek wrote: > ... > > > > > The default permissions for the device are 600. > > > > > > > > Good. This does not belong to non-root. > > > > > > There are entirely legitimate use cases for using

Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-09 Thread Josh Triplett
On Sun, Dec 09, 2018 at 09:06:00PM +0100, Pavel Machek wrote: ... > > > > The default permissions for the device are 600. > > > > > > Good. This does not belong to non-root. > > > > There are entirely legitimate use cases for using this as an > > unprivileged user. However, that'll be up to

Re: [PATCH v11 00/13] Intel SGX1 support

2018-12-09 Thread Pavel Machek
Hi! (sorry to bring up old thread). > > > > > Intel(R) SGX is a set of CPU instructions that can be used by > > > > > applications > > > > > to set aside private regions of code and data. The code outside the > > > > > enclave > > > > > is disallowed to access the memory inside the enclave by

Re: [PATCH v11 00/13] Intel SGX1 support

2018-06-25 Thread Jarkko Sakkinen
On Thu, 2018-06-21 at 14:55 +0200, Ingo Molnar wrote: > Just some quick feedback: these are core kernel functionality and should be > in > arch/x86/, not in drivers/platform/. We have in core what is used by both KVM and the driver right now (EPC management, SGX detection and some other bits).

Re: [PATCH v11 00/13] Intel SGX1 support

2018-06-25 Thread Jarkko Sakkinen
On Thu, 2018-06-21 at 14:55 +0200, Ingo Molnar wrote: > Just some quick feedback: these are core kernel functionality and should be > in > arch/x86/, not in drivers/platform/. We have in core what is used by both KVM and the driver right now (EPC management, SGX detection and some other bits).

Re: [PATCH v11 00/13] Intel SGX1 support

2018-06-21 Thread Ingo Molnar
* Jarkko Sakkinen wrote: > create mode 100644 drivers/platform/x86/intel_sgx/Kconfig > create mode 100644 drivers/platform/x86/intel_sgx/Makefile > create mode 100644 drivers/platform/x86/intel_sgx/le/Makefile > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/Makefile >

Re: [PATCH v11 00/13] Intel SGX1 support

2018-06-21 Thread Ingo Molnar
* Jarkko Sakkinen wrote: > create mode 100644 drivers/platform/x86/intel_sgx/Kconfig > create mode 100644 drivers/platform/x86/intel_sgx/Makefile > create mode 100644 drivers/platform/x86/intel_sgx/le/Makefile > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/Makefile >