RE: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-24 Thread Jolly Shah
...@gmail.com; Kees Cook ; Dmitry > Torokhov ; Michael Turquette > ; Stephen Boyd ; Michal > Simek ; Rob Herring ; Mark Rutland > ; linux-clk ; Rajan Vaja > ; Linux ARM Mailing List ker...@lists.infradead.org>; Linux Kernel Mailing List ker...@vger.kernel.org>; DTML > Subj

RE: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-24 Thread Jolly Shah
...@gmail.com; Kees Cook ; Dmitry > Torokhov ; Michael Turquette > ; Stephen Boyd ; Michal > Simek ; Rob Herring ; Mark Rutland > ; linux-clk ; Rajan Vaja > ; Linux ARM Mailing List ker...@lists.infradead.org>; Linux Kernel Mailing List ker...@vger.kernel.org>; DTML > Subj

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-23 Thread Olof Johansson
Hi, Apologies for the slow responses here, I meant to follow up on this sooner. On Tue, Sep 11, 2018 at 8:20 PM, Jolly Shah wrote: > Hi Sudeep and Olof, > > Clock driver from same patch set uses ioctl API along with other clock eemi > APIs. As clock patches' final review is pending by Stephen,

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-23 Thread Olof Johansson
Hi, Apologies for the slow responses here, I meant to follow up on this sooner. On Tue, Sep 11, 2018 at 8:20 PM, Jolly Shah wrote: > Hi Sudeep and Olof, > > Clock driver from same patch set uses ioctl API along with other clock eemi > APIs. As clock patches' final review is pending by Stephen,

RE: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-11 Thread Jolly Shah
uk; Sudeep > Holla ; hkallwe...@gmail.com; Kees Cook > ; Dmitry Torokhov ; > Michael Turquette ; Stephen Boyd > ; Michal Simek ; Rob Herring > ; Mark Rutland ; linux-clk > ; Rajan Vaja ; Linux ARM > Mailing List ; Linux Kernel Mailing List > ; DTML > Subject: Re: [PATCH v11

RE: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-11 Thread Jolly Shah
uk; Sudeep > Holla ; hkallwe...@gmail.com; Kees Cook > ; Dmitry Torokhov ; > Michael Turquette ; Stephen Boyd > ; Michal Simek ; Rob Herring > ; Mark Rutland ; linux-clk > ; Rajan Vaja ; Linux ARM > Mailing List ; Linux Kernel Mailing List > ; DTML > Subject: Re: [PATCH v11

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-11 Thread Olof Johansson
Hi Jolly, On Mon, Sep 10, 2018 at 12:17 PM, Jolly Shah wrote: > Hi All, > > Adding more clarification on top of what Michal said: > Here ioctl is not a system ioctl and just a eemi API like other interface > APIs. It cannot be called from userspace. Only Linux drivers can use this API > for

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-11 Thread Olof Johansson
Hi Jolly, On Mon, Sep 10, 2018 at 12:17 PM, Jolly Shah wrote: > Hi All, > > Adding more clarification on top of what Michal said: > Here ioctl is not a system ioctl and just a eemi API like other interface > APIs. It cannot be called from userspace. Only Linux drivers can use this API > for

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-11 Thread Sudeep Holla
On Mon, Sep 10, 2018 at 07:17:45PM +, Jolly Shah wrote: > Hi All, > > Adding more clarification on top of what Michal said: > Here ioctl is not a system ioctl and just a eemi API like other interface > APIs. It cannot be called from userspace. I get that these are not system ioctl and you

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-11 Thread Sudeep Holla
On Mon, Sep 10, 2018 at 07:17:45PM +, Jolly Shah wrote: > Hi All, > > Adding more clarification on top of what Michal said: > Here ioctl is not a system ioctl and just a eemi API like other interface > APIs. It cannot be called from userspace. I get that these are not system ioctl and you

RE: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Jolly Shah
el Turquette ; Stephen Boyd > ; Michal Simek ; Rob Herring > ; Mark Rutland ; linux-clk > ; Rajan Vaja ; Linux ARM > Mailing List ; Linux Kernel Mailing List > ; DTML ; Jolly > Shah > Subject: Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for > device control &

RE: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Jolly Shah
el Turquette ; Stephen Boyd > ; Michal Simek ; Rob Herring > ; Mark Rutland ; linux-clk > ; Rajan Vaja ; Linux ARM > Mailing List ; Linux Kernel Mailing List > ; DTML ; Jolly > Shah > Subject: Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for > device control &

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Michal Simek
On 9.9.2018 21:20, Moritz Fischer wrote: > Hi Olof, > > On Sat, Sep 8, 2018 at 6:18 PM, Olof Johansson wrote: >> Hi, >> >> On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >>> From: Rajan Vaja >>> >>> Add ZynqMP firmware IOCTL API to control and configure >>> devices like PLLs, SD, Gem, etc.

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Michal Simek
On 9.9.2018 21:20, Moritz Fischer wrote: > Hi Olof, > > On Sat, Sep 8, 2018 at 6:18 PM, Olof Johansson wrote: >> Hi, >> >> On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >>> From: Rajan Vaja >>> >>> Add ZynqMP firmware IOCTL API to control and configure >>> devices like PLLs, SD, Gem, etc.

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Michal Simek
On 9.9.2018 03:18, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by: Jolly Shah > > This

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Michal Simek
On 9.9.2018 03:18, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by: Jolly Shah > > This

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Sudeep Holla
On 09/09/18 02:18, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by: Jolly Shah > > This

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-10 Thread Sudeep Holla
On 09/09/18 02:18, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by: Jolly Shah > > This

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-09 Thread Moritz Fischer
Hi Olof, On Sat, Sep 8, 2018 at 6:18 PM, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by:

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-09 Thread Moritz Fischer
Hi Olof, On Sat, Sep 8, 2018 at 6:18 PM, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by:

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-08 Thread Olof Johansson
Hi, On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: > From: Rajan Vaja > > Add ZynqMP firmware IOCTL API to control and configure > devices like PLLs, SD, Gem, etc. > > Signed-off-by: Rajan Vaja > Signed-off-by: Jolly Shah This patch worries me somewhat. It's a transparent pass-through

Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-09-08 Thread Olof Johansson
Hi, On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: > From: Rajan Vaja > > Add ZynqMP firmware IOCTL API to control and configure > devices like PLLs, SD, Gem, etc. > > Signed-off-by: Rajan Vaja > Signed-off-by: Jolly Shah This patch worries me somewhat. It's a transparent pass-through

[PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-08-03 Thread Jolly Shah
From: Rajan Vaja Add ZynqMP firmware IOCTL API to control and configure devices like PLLs, SD, Gem, etc. Signed-off-by: Rajan Vaja Signed-off-by: Jolly Shah --- drivers/firmware/xilinx/zynqmp.c | 20 include/linux/firmware/xlnx-zynqmp.h | 2 ++ 2 files changed, 22

[PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control

2018-08-03 Thread Jolly Shah
From: Rajan Vaja Add ZynqMP firmware IOCTL API to control and configure devices like PLLs, SD, Gem, etc. Signed-off-by: Rajan Vaja Signed-off-by: Jolly Shah --- drivers/firmware/xilinx/zynqmp.c | 20 include/linux/firmware/xlnx-zynqmp.h | 2 ++ 2 files changed, 22