Re: [PATCH v11 09/12] soc: mediatek: cmdq: define the instruction struct

2019-08-10 Thread houlong wei
On Sun, 2019-08-11 at 00:12 +0800, houlong wei wrote: > Hi Bibby, I have inline comment in function cmdq_pkt_write_mask(). > > On Mon, 2019-07-29 at 15:01 +0800, Bibby Hsieh wrote: > > Define an instruction structure for gce driver to append command. > > This structure can make the client's code

Re: [PATCH v11 09/12] soc: mediatek: cmdq: define the instruction struct

2019-08-10 Thread houlong wei
Hi Bibby, I have inline comment in function cmdq_pkt_write_mask(). On Mon, 2019-07-29 at 15:01 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh >

[PATCH v11 09/12] soc: mediatek: cmdq: define the instruction struct

2019-07-29 Thread Bibby Hsieh
Define an instruction structure for gce driver to append command. This structure can make the client's code more readability. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-cmdq-helper.c | 103 +++ include/linux/mailbox/mtk-cmdq-mailbox.h | 2