Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

Hello, On (04/22/16 10:41), Petr Mladek wrote: > Ah, I see and feel shame. It is actually explained in the comment > above printk_initcall_done declaration. Well, the explanation confused > me a bit ;-) I suggest to change it sligtly: > > /* > * printk_sync_set() can be called from two places:

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

Hello, On (04/22/16 10:41), Petr Mladek wrote: > Ah, I see and feel shame. It is actually explained in the comment > above printk_initcall_done declaration. Well, the explanation confused > me a bit ;-) I suggest to change it sligtly: > > /* > * printk_sync_set() can be called from two places:

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On Fri 2016-04-22 10:28:26, Sergey Senozhatsky wrote: > Hello, > > On (04/21/16 13:07), Petr Mladek wrote: > [..] > > Please, what is the purpose of "printk_initcall_done" then? If I get > > this correctly, it will always be true when printk_sync_set() is > > called. > > well, this is a bit

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On Fri 2016-04-22 10:28:26, Sergey Senozhatsky wrote: > Hello, > > On (04/21/16 13:07), Petr Mladek wrote: > [..] > > Please, what is the purpose of "printk_initcall_done" then? If I get > > this correctly, it will always be true when printk_sync_set() is > > called. > > well, this is a bit

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

Hello, On (04/21/16 13:07), Petr Mladek wrote: [..] > Please, what is the purpose of "printk_initcall_done" then? If I get > this correctly, it will always be true when printk_sync_set() is > called. well, this is a bit ugly, yes. kernel_param_ops defines ->set callback as printk_sync_set(). and

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

Hello, On (04/21/16 13:07), Petr Mladek wrote: [..] > Please, what is the purpose of "printk_initcall_done" then? If I get > this correctly, it will always be true when printk_sync_set() is > called. well, this is a bit ugly, yes. kernel_param_ops defines ->set callback as printk_sync_set(). and

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On Fri 2016-04-08 14:29:27, Sergey Senozhatsky wrote: > On (04/08/16 12:04), Pan Xinhui wrote: > [..] > > > +/* > > > + * Init async printk via late_initcall, after core/arch/device/etc. > > > + * initialization. > > > + */ > > > +static __init int init_printk_kthread(void) > > > +{ > > > +

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On Fri 2016-04-08 14:29:27, Sergey Senozhatsky wrote: > On (04/08/16 12:04), Pan Xinhui wrote: > [..] > > > +/* > > > + * Init async printk via late_initcall, after core/arch/device/etc. > > > + * initialization. > > > + */ > > > +static __init int init_printk_kthread(void) > > > +{ > > > +

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On (04/20/16 17:16), Jan Kara wrote: [..] > I finally found time to have a look. The patch looks good to me. You can > add: > > Reviewed-by: Jan Kara thanks. -ss

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On (04/20/16 17:16), Jan Kara wrote: [..] > I finally found time to have a look. The patch looks good to me. You can > add: > > Reviewed-by: Jan Kara thanks. -ss

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On Fri 08-04-16 02:31:47, Sergey Senozhatsky wrote: > Change `synchronous' printk param to be RW, so user space > can change printk mode back and forth to/from sync mode > (which is considered to be more reliable). > > Signed-off-by: Sergey Senozhatsky I finally

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On Fri 08-04-16 02:31:47, Sergey Senozhatsky wrote: > Change `synchronous' printk param to be RW, so user space > can change printk mode back and forth to/from sync mode > (which is considered to be more reliable). > > Signed-off-by: Sergey Senozhatsky I finally found time to have a look. The

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On 2016年04月08日 13:29, Sergey Senozhatsky wrote: > On (04/08/16 12:04), Pan Xinhui wrote: > [..] >>> +/* >>> + * Init async printk via late_initcall, after core/arch/device/etc. >>> + * initialization. >>> + */ >>> +static __init int init_printk_kthread(void) >>> +{ >>> + printk_initcall_done =

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On 2016年04月08日 13:29, Sergey Senozhatsky wrote: > On (04/08/16 12:04), Pan Xinhui wrote: > [..] >>> +/* >>> + * Init async printk via late_initcall, after core/arch/device/etc. >>> + * initialization. >>> + */ >>> +static __init int init_printk_kthread(void) >>> +{ >>> + printk_initcall_done =

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On (04/08/16 12:04), Pan Xinhui wrote: [..] > > +/* > > + * Init async printk via late_initcall, after core/arch/device/etc. > > + * initialization. > > + */ > > +static __init int init_printk_kthread(void) > > +{ > > + printk_initcall_done = true; > > + return __init_printk_kthread(); >

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On (04/08/16 12:04), Pan Xinhui wrote: [..] > > +/* > > + * Init async printk via late_initcall, after core/arch/device/etc. > > + * initialization. > > + */ > > +static __init int init_printk_kthread(void) > > +{ > > + printk_initcall_done = true; > > + return __init_printk_kthread(); >

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On 2016年04月08日 01:31, Sergey Senozhatsky wrote: > Change `synchronous' printk param to be RW, so user space > can change printk mode back and forth to/from sync mode > (which is considered to be more reliable). > > Signed-off-by: Sergey Senozhatsky > --- >

Re: [PATCH v11 3/3] printk: make printk.synchronous param rw

On 2016年04月08日 01:31, Sergey Senozhatsky wrote: > Change `synchronous' printk param to be RW, so user space > can change printk mode back and forth to/from sync mode > (which is considered to be more reliable). > > Signed-off-by: Sergey Senozhatsky > --- > kernel/printk/printk.c | 63 >

[PATCH v11 3/3] printk: make printk.synchronous param rw

Change `synchronous' printk param to be RW, so user space can change printk mode back and forth to/from sync mode (which is considered to be more reliable). Signed-off-by: Sergey Senozhatsky --- kernel/printk/printk.c | 63

[PATCH v11 3/3] printk: make printk.synchronous param rw

Change `synchronous' printk param to be RW, so user space can change printk mode back and forth to/from sync mode (which is considered to be more reliable). Signed-off-by: Sergey Senozhatsky --- kernel/printk/printk.c | 63 ++ 1 file changed, 53