Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

> > > Though I normally prefer static inline functions, I see the benefits of > > > using the macro form here. > > An inline could still work > static inline void __user *u64_to_user_ptr(u64 address) > { > return (void __user *)(uintptr_t)address; > } > if

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

> > > Though I normally prefer static inline functions, I see the benefits of > > > using the macro form here. > > An inline could still work > static inline void __user *u64_to_user_ptr(u64 address) > { > return (void __user *)(uintptr_t)address; > } > if

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

On Tue, 2016-04-26 at 11:29 -0300, Gustavo Padovan wrote: > 2016-04-26 Lucas Stach : > > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > > From: Gustavo Padovan > > > > > > This function had copies in 3 different

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

On Tue, 2016-04-26 at 11:29 -0300, Gustavo Padovan wrote: > 2016-04-26 Lucas Stach : > > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > > From: Gustavo Padovan > > > > > > This function had copies in 3 different files. Unify them in kernel.h. > > > > > > Cc: Joe Perches

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

2016-04-26 Lucas Stach : > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > From: Gustavo Padovan > > > > This function had copies in 3 different files. Unify them in kernel.h. > > > > Cc: Joe Perches

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

2016-04-26 Lucas Stach : > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > From: Gustavo Padovan > > > > This function had copies in 3 different files. Unify them in kernel.h. > > > > Cc: Joe Perches > > Cc: Andrew Morton > > Cc: David Airlie > > Cc: Daniel Vetter >

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton > Cc:

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > Signed-off-by: Gustavo

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

Op 22-04-16 om 17:13 schreef Rob Clark: > On Thu, Apr 21, 2016 at 11:38 AM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> This function had copies in 3 different files. Unify them in kernel.h. >> >> Cc: Joe Perches

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

Op 22-04-16 om 17:13 schreef Rob Clark: > On Thu, Apr 21, 2016 at 11:38 AM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> This function had copies in 3 different files. Unify them in kernel.h. >> >> Cc: Joe Perches >> Cc: Andrew Morton >> Cc: David Airlie >> Cc: Daniel Vetter >> Cc:

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

On Thu, Apr 21, 2016 at 11:38 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

On Thu, Apr 21, 2016 at 11:38 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > Signed-off-by: Gustavo Padovan

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

2016-04-22 Daniel Vetter : > On Thu, Apr 21, 2016 at 12:38:49PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > This function had copies in 3 different files. Unify them in kernel.h. > > > > Cc: Joe Perches >

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

2016-04-22 Daniel Vetter : > On Thu, Apr 21, 2016 at 12:38:49PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > This function had copies in 3 different files. Unify them in kernel.h. > > > > Cc: Joe Perches > > Cc: Andrew Morton > > Cc: David Airlie > > Cc: Daniel Vetter >

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

On Thu, Apr 21, 2016 at 12:38:49PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton > Cc: David

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

On Thu, Apr 21, 2016 at 12:38:49PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > Signed-off-by: Gustavo

[PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

From: Gustavo Padovan This function had copies in 3 different files. Unify them in kernel.h. Cc: Joe Perches Cc: Andrew Morton Cc: David Airlie Cc: Daniel Vetter Cc: Rob

[PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

From: Gustavo Padovan This function had copies in 3 different files. Unify them in kernel.h. Cc: Joe Perches Cc: Andrew Morton Cc: David Airlie Cc: Daniel Vetter Cc: Rob Clark Signed-off-by: Gustavo Padovan --- v2: add typecheck() (comment from Maarten Lankhorst) v3: make